Re: [PATCH -next] swiotlb: drop pointless static qualifier in swiotlb_dma_supported()

2019-02-14 Thread YueHaibing
On 2019/2/14 15:26, Christoph Hellwig wrote: > On Thu, Feb 14, 2019 at 01:41:47AM +, YueHaibing wrote: >> There is no need to have the 'struct dentry *d_swiotlb_usage' variable >> static since new value always be assigned before use it. > > FYI, this is in swiotlb_create_debugfs, not swiotlb_d

Re: [PATCH -next] swiotlb: drop pointless static qualifier in swiotlb_dma_supported()

2019-02-13 Thread Christoph Hellwig
On Thu, Feb 14, 2019 at 01:41:47AM +, YueHaibing wrote: > There is no need to have the 'struct dentry *d_swiotlb_usage' variable > static since new value always be assigned before use it. FYI, this is in swiotlb_create_debugfs, not swiotlb_dma_supported.

[PATCH -next] swiotlb: drop pointless static qualifier in swiotlb_dma_supported()

2019-02-13 Thread YueHaibing
There is no need to have the 'struct dentry *d_swiotlb_usage' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- kernel/dma/swiotlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index