Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-16 Thread Christian König
Am 16.09.20 um 15:36 schrieb Alex Deucher: On Wed, Sep 16, 2020 at 3:51 AM Daniel Vetter wrote: On Wed, Sep 16, 2020 at 09:38:34AM +0200, Christian König wrote: Am 15.09.20 um 21:35 schrieb Ville Syrjälä: On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote: I question the value of t

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 04:02:18PM +0200, Christian König wrote: > Am 16.09.20 um 15:36 schrieb Alex Deucher: > > On Wed, Sep 16, 2020 at 3:51 AM Daniel Vetter wrote: > > > On Wed, Sep 16, 2020 at 09:38:34AM +0200, Christian König wrote: > > > > Am 15.09.20 um 21:35 schrieb Ville Syrjälä: > > > >

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-16 Thread Alex Deucher
On Wed, Sep 16, 2020 at 3:51 AM Daniel Vetter wrote: > > On Wed, Sep 16, 2020 at 09:38:34AM +0200, Christian König wrote: > > Am 15.09.20 um 21:35 schrieb Ville Syrjälä: > > > On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote: > > > > I question the value of these warnings. Why even ha

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 09:38:34AM +0200, Christian König wrote: > Am 15.09.20 um 21:35 schrieb Ville Syrjälä: > > On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote: > > > I question the value of these warnings. Why even have a boolean type > > > if you are going to get warnings when yo

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-16 Thread Christian König
Am 15.09.20 um 21:35 schrieb Ville Syrjälä: On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote: I question the value of these warnings. Why even have a boolean type if you are going to get warnings when you use them... That said, applied to avoid getting these patches again and again

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-15 Thread Ville Syrjälä
On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote: > I question the value of these warnings. Why even have a boolean type > if you are going to get warnings when you use them... > That said, applied to avoid getting these patches again and again > every time someone sees this. if (this

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-15 Thread Alex Deucher
I question the value of these warnings. Why even have a boolean type if you are going to get warnings when you use them... That said, applied to avoid getting these patches again and again every time someone sees this. Alex On Wed, Sep 9, 2020 at 9:21 AM Christian König wrote: > > Acked-by: Chr

Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-09 Thread Christian König
Acked-by: Christian König for the series. Am 09.09.20 um 15:07 schrieb Zheng Bin: Zheng Bin (8): drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c drm/amd/amdgpu: fix comparison pointer to bool war

[PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

2020-09-09 Thread Zheng Bin
Zheng Bin (8): drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2