Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Rick Jones
On 06/02/2016 10:06 AM, Aaron Conole wrote: Rick Jones writes: One of the things I've been doing has been setting-up a cluster (OpenStack) with JumboFrames, and then setting MTUs on instance vNICs by hand to measure different MTU sizes. It would be a shame if such a thing

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Rick Jones
On 06/02/2016 10:06 AM, Aaron Conole wrote: Rick Jones writes: One of the things I've been doing has been setting-up a cluster (OpenStack) with JumboFrames, and then setting MTUs on instance vNICs by hand to measure different MTU sizes. It would be a shame if such a thing were not possible in

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
kbuild test robot writes: > Hi, > > [auto build test ERROR on next-20160602] > > url: > https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-1)

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
kbuild test robot writes: > Hi, > > [auto build test ERROR on next-20160602] > > url: > https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 >

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread kbuild test robot
Hi, [auto build test ERROR on next-20160602] url: https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread kbuild test robot
Hi, [auto build test ERROR on next-20160602] url: https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case where a

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case where a user changes the

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
Hi Rick, In the future, please don't cut the list. Rick Jones writes: > On 06/02/2016 08:43 AM, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
Hi Rick, In the future, please don't cut the list. Rick Jones writes: > On 06/02/2016 08:43 AM, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Michael S. Tsirkin
On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Michael S. Tsirkin
On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit

[PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper error handling. Instead, a warning is emitted if the guest

[PATCH -next 2/2] virtio_net: Read the advised MTU

2016-06-02 Thread Aaron Conole
This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it exists, read the advised MTU and use it. No proper error handling is provided for the case where a user changes the negotiated MTU. A future commit will add proper error handling. Instead, a warning is emitted if the guest