Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-07 Thread Joel Fernandes
On Fri, Sep 06, 2019 at 10:16:47AM -0700, Paul E. McKenney wrote: > On Fri, Sep 06, 2019 at 12:57:51PM -0400, Joel Fernandes wrote: > > On Fri, Sep 06, 2019 at 08:27:53AM -0700, Paul E. McKenney wrote: > > > On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > > > > On Fri, Sep 06, 2

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Joel Fernandes
On Fri, Sep 06, 2019 at 10:16:47AM -0700, Paul E. McKenney wrote: > On Fri, Sep 06, 2019 at 12:57:51PM -0400, Joel Fernandes wrote: > > On Fri, Sep 06, 2019 at 08:27:53AM -0700, Paul E. McKenney wrote: > > > On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > > > > On Fri, Sep 06, 2

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Paul E. McKenney
On Fri, Sep 06, 2019 at 12:57:51PM -0400, Joel Fernandes wrote: > On Fri, Sep 06, 2019 at 08:27:53AM -0700, Paul E. McKenney wrote: > > On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > > > On Fri, Sep 06, 2019 at 11:08:06AM -0400, Joel Fernandes wrote: > > > > On Thu, Sep 05, 201

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Joel Fernandes
On Fri, Sep 06, 2019 at 08:27:53AM -0700, Paul E. McKenney wrote: > On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > > On Fri, Sep 06, 2019 at 11:08:06AM -0400, Joel Fernandes wrote: > > > On Thu, Sep 05, 2019 at 08:01:37PM -0400, Joel Fernandes wrote: > > > [snip] > > > > > > >

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Paul E. McKenney
On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > On Fri, Sep 06, 2019 at 11:08:06AM -0400, Joel Fernandes wrote: > > On Thu, Sep 05, 2019 at 08:01:37PM -0400, Joel Fernandes wrote: > > [snip] > > > > > > @@ -3004,7 +3007,7 @@ static int rcu_pending(void) > > > > > >

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Paul E. McKenney
On Fri, Sep 06, 2019 at 11:08:06AM -0400, Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 08:01:37PM -0400, Joel Fernandes wrote: > [snip] > > > > > @@ -3004,7 +3007,7 @@ static int rcu_pending(void) > > > > > return 0; > > > > > > > > > > /* Is the RCU core waiting for a qui

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-06 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 08:01:37PM -0400, Joel Fernandes wrote: [snip] > > > > @@ -3004,7 +3007,7 @@ static int rcu_pending(void) > > > > return 0; > > > > > > > > /* Is the RCU core waiting for a quiescent state from this CPU? > > > > */ > > > > - if (rdp->core_ne

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 09:43:29AM -0700, Paul E. McKenney wrote: > On Thu, Sep 05, 2019 at 11:36:20AM -0400, Joel Fernandes wrote: > > On Wed, Sep 04, 2019 at 04:13:08PM -0700, Paul E. McKenney wrote: > > > On Wed, Sep 04, 2019 at 09:54:20AM -0400, Joel Fernandes wrote: > > > > On Wed, Sep 04, 201

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-05 Thread Paul E. McKenney
On Thu, Sep 05, 2019 at 11:36:20AM -0400, Joel Fernandes wrote: > On Wed, Sep 04, 2019 at 04:13:08PM -0700, Paul E. McKenney wrote: > > On Wed, Sep 04, 2019 at 09:54:20AM -0400, Joel Fernandes wrote: > > > On Wed, Sep 04, 2019 at 03:12:10AM -0700, Paul E. McKenney wrote: > > > > On Wed, Sep 04, 201

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-05 Thread Joel Fernandes
On Wed, Sep 04, 2019 at 04:13:08PM -0700, Paul E. McKenney wrote: > On Wed, Sep 04, 2019 at 09:54:20AM -0400, Joel Fernandes wrote: > > On Wed, Sep 04, 2019 at 03:12:10AM -0700, Paul E. McKenney wrote: > > > On Wed, Sep 04, 2019 at 12:59:10AM -0400, Joel Fernandes wrote: > > > > On Tue, Sep 03, 201

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-04 Thread Paul E. McKenney
On Wed, Sep 04, 2019 at 09:54:20AM -0400, Joel Fernandes wrote: > On Wed, Sep 04, 2019 at 03:12:10AM -0700, Paul E. McKenney wrote: > > On Wed, Sep 04, 2019 at 12:59:10AM -0400, Joel Fernandes wrote: > > > On Tue, Sep 03, 2019 at 01:02:49PM -0700, Paul E. McKenney wrote: [ . . . ] > > If this tas

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-04 Thread Joel Fernandes
On Wed, Sep 04, 2019 at 03:12:10AM -0700, Paul E. McKenney wrote: > On Wed, Sep 04, 2019 at 12:59:10AM -0400, Joel Fernandes wrote: > > On Tue, Sep 03, 2019 at 01:02:49PM -0700, Paul E. McKenney wrote: > > [snip] > > > > --- > > > > include/linux/rcutiny.h | 3 -- > > > > kernel/rcu/tree.c

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-04 Thread Paul E. McKenney
On Wed, Sep 04, 2019 at 12:59:10AM -0400, Joel Fernandes wrote: > On Tue, Sep 03, 2019 at 01:02:49PM -0700, Paul E. McKenney wrote: > [snip] > > > --- > > > include/linux/rcutiny.h | 3 -- > > > kernel/rcu/tree.c | 82 ++--- > > > 2 files changed, 19 ins

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-03 Thread Joel Fernandes
On Tue, Sep 03, 2019 at 01:02:49PM -0700, Paul E. McKenney wrote: [snip] > > --- > > include/linux/rcutiny.h | 3 -- > > kernel/rcu/tree.c | 82 ++--- > > 2 files changed, 19 insertions(+), 66 deletions(-) > > > > diff --git a/include/linux/rcutiny.h b/

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-09-03 Thread Paul E. McKenney
On Fri, Aug 30, 2019 at 12:23:47PM -0400, Joel Fernandes (Google) wrote: > This code is unused and can be removed now. Revert was straightforward. > > Tested with light rcutorture. > > Link: > http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com > Suggested

[PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

2019-08-30 Thread Joel Fernandes (Google)
This code is unused and can be removed now. Revert was straightforward. Tested with light rcutorture. Link: http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com Suggested-by: Andy Lutomirski Signed-off-by: Joel Fernandes (Google) --- include/linux/rcuti