Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-20 Thread Paul E. McKenney
On Tue, Aug 20, 2019 at 02:08:45PM +0200, Frederic Weisbecker wrote: > On Mon, Aug 19, 2019 at 09:44:20AM -0700, Paul E. McKenney wrote: > > On Mon, Aug 19, 2019 at 06:32:27PM +0200, Frederic Weisbecker wrote: > > > > But would the following patch make sense? This would not help for (say) > > > >

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-20 Thread Frederic Weisbecker
On Mon, Aug 19, 2019 at 09:44:20AM -0700, Paul E. McKenney wrote: > On Mon, Aug 19, 2019 at 06:32:27PM +0200, Frederic Weisbecker wrote: > > > But would the following patch make sense? This would not help for (say) > > > use of TICK_MASK_BIT_POSIX_TIMER instead of TICK_DEP_BIT_POSIX_TIMER, but > >

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2019 at 06:32:27PM +0200, Frederic Weisbecker wrote: > On Mon, Aug 19, 2019 at 07:46:32AM -0700, Paul E. McKenney wrote: > > On Mon, Aug 19, 2019 at 02:38:38PM +0200, Frederic Weisbecker wrote: > > > On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > > > > Th

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-19 Thread Frederic Weisbecker
On Mon, Aug 19, 2019 at 07:46:32AM -0700, Paul E. McKenney wrote: > On Mon, Aug 19, 2019 at 02:38:38PM +0200, Frederic Weisbecker wrote: > > On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > > > This commit fixes the issue. > > > > > > Signed-off-by: Joel Fernandes (Google

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2019 at 02:38:38PM +0200, Frederic Weisbecker wrote: > On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > > This commit fixes the issue. > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/tree.c | 29 + > > 1

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-19 Thread Frederic Weisbecker
On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > This commit fixes the issue. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/tree.c | 29 + > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/kernel/rcu/tree.c

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 10:25:29AM -0700, Paul E. McKenney wrote: > On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > > This commit fixes the issue. > > > > Signed-off-by: Joel Fernandes (Google) > > And I am squashing these into their respective commits with attribution

Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-16 Thread Paul E. McKenney
On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > This commit fixes the issue. > > Signed-off-by: Joel Fernandes (Google) And I am squashing these into their respective commits with attribution. Good eyes, thank you very much!!!

[PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks

2019-08-15 Thread Joel Fernandes (Google)
This commit fixes the issue. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 0512de9ead20..322b1b57967c 100644 --- a/kernel/rcu/tree.c +++