Re: [PATCH -rt] irq nobody cared workaround for i386

2007-06-22 Thread Thomas Gleixner
On Thu, 2007-06-21 at 13:31 +0200, Michal Schmidt wrote: > OK, I fixed the spacing in both occurences. > > Signed-off-by: Michal Schmidt <[EMAIL PROTECTED]> > > --- arch/i386/kernel/io_apic.c.orig 2007-06-19 08:40:05.0 -0400 > +++ arch/i386/kernel/io_apic.c2007-06-21 06:51:16.00

Re: [PATCH -rt] irq nobody cared workaround for i386

2007-06-21 Thread Michal Schmidt
Steven Rostedt wrote: > Michal Schmidt wrote: > >> I came to the conclusion that the IO-APICs which need the fix for the >> nobody cared bug don't have the issue ack_ioapic_quirk_irq is designed >> to work-around. It should be safe simply to use the normal >> ack_ioapic_irq as the .eoi method in

Re: [PATCH -rt] irq nobody cared workaround for i386

2007-06-20 Thread Steven Rostedt
Michal Schmidt wrote: Michal Schmidt wrote: I came to the conclusion that the IO-APICs which need the fix for the nobody cared bug don't have the issue ack_ioapic_quirk_irq is designed to work-around. It should be safe simply to use the normal ack_ioapic_irq as the .eoi method in pcix_ioapic_c

Re: [PATCH -rt] irq nobody cared workaround for i386

2007-06-20 Thread Michal Schmidt
Michal Schmidt wrote: > Steven Rostedt wrote: > >> This is the final "design" for the nobody cared bug. For all IO-APICS >> other than the first one (the chained IO-APICS) we use the PCIX version >> of the mask and unmask interrupt routines. This changes the interrupt >> from level to edge f

[PATCH -rt] irq nobody cared workaround for i386

2007-06-19 Thread Michal Schmidt
Steven Rostedt wrote: > This is the final "design" for the nobody cared bug. For all IO-APICS > other than the first one (the chained IO-APICS) we use the PCIX version > of the mask and unmask interrupt routines. This changes the interrupt > from level to edge for mask and edge to level for unm