Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 12, 2012 at 04:57:45PM +0900, Hyeoncheol Lee escreveu: > +++ b/tools/perf/util/probe-finder.c > @@ -525,8 +525,10 @@ static int convert_variable_fields(Dwarf_Die > *vr_die, const char *varname, [acme@sandy linux]$ am /wb/1.patch Applying: perf probe: Add union member access support

Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Masami Hiramatsu
(2012/09/12 16:57), Hyeoncheol Lee wrote: > Union members can be accessed with '.' or '->' like data structure > member access This seems good to me :) Acked-by: Masami Hiramatsu Thank you! > > Cc: Masami Hiramatsu > Cc: Srikar Dronamraju > Signed-off-by: Hyunchul Lee > --- >

Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Namhyung Kim
Hi Hyeoncheol, It seems you don't use git send-email which adds people on Cc: lines of changelog into actual CC list automatically. Or did you send the email to Masami and Srikar privately? Thanks, Namhyung On Wed, 12 Sep 2012 16:57:45 +0900, Hyeoncheol Lee wrote: > Union members can be

[PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Hyeoncheol Lee
Union members can be accessed with '.' or '->' like data structure member access Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyunchul Lee --- tools/perf/util/probe-finder.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Hyeoncheol Lee
Union members can be accessed with '.' or '-' like data structure member access Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyunchul Lee hyc@gmail.com --- tools/perf/util/probe-finder.c | 24 1

Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Namhyung Kim
Hi Hyeoncheol, It seems you don't use git send-email which adds people on Cc: lines of changelog into actual CC list automatically. Or did you send the email to Masami and Srikar privately? Thanks, Namhyung On Wed, 12 Sep 2012 16:57:45 +0900, Hyeoncheol Lee wrote: Union members can be

Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Masami Hiramatsu
(2012/09/12 16:57), Hyeoncheol Lee wrote: Union members can be accessed with '.' or '-' like data structure member access This seems good to me :) Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com Thank you! Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar

Re: [PATCH -tip/perf/core] perf probe: Add union member access support

2012-09-12 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 12, 2012 at 04:57:45PM +0900, Hyeoncheol Lee escreveu: +++ b/tools/perf/util/probe-finder.c @@ -525,8 +525,10 @@ static int convert_variable_fields(Dwarf_Die *vr_die, const char *varname, [acme@sandy linux]$ am /wb/1.patch Applying: perf probe: Add union member access support