Re: [PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if asked for variable it doesn't find

2014-05-29 Thread Masami Hiramatsu
(2014/05/30 15:03), Namhyung Kim wrote: > Hi Masami, > > On Thu, 29 May 2014 19:52:32 +0900, Masami Hiramatsu wrote: >> Fix a segfault bug by asking for variable it doesn't find. >> Since the convert_variable() didn't handle error code returned >> from convert_variable_location(), it just passed a

Re: [PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if asked for variable it doesn't find

2014-05-29 Thread Namhyung Kim
Hi Masami, On Thu, 29 May 2014 19:52:32 +0900, Masami Hiramatsu wrote: > Fix a segfault bug by asking for variable it doesn't find. > Since the convert_variable() didn't handle error code returned > from convert_variable_location(), it just passed an incomplete > variable field and then a segfault

Re: [PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if asked for variable it doesn't find

2014-05-29 Thread Masami Hiramatsu
Arnaldo, this fixes the SEGV bug which you reported. But I've found that perf probe sometimes loses the location of variables with recent DWARF implementation. I need to check and fix that too. Anyway, this patch should be applied for fixing critical bug. Thank you, (2014/05/29 19:52), Masami H

[PATCH -tip/urgent ] [BUGFIX] perf/probe: Fix a segfault if asked for variable it doesn't find

2014-05-29 Thread Masami Hiramatsu
Fix a segfault bug by asking for variable it doesn't find. Since the convert_variable() didn't handle error code returned from convert_variable_location(), it just passed an incomplete variable field and then a segfault was occured when formatting the field. This fixes that bug by handling success