Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-26 Thread Peter Zijlstra
On Thu, Nov 26, 2020 at 10:17:15AM +1100, Balbir Singh wrote: > On Tue, Nov 24, 2020 at 10:09:55AM +0100, Peter Zijlstra wrote: > > The basic observation the current approach relies on is that al that > > faffery basically boils down to the fact that vruntime only means > > something when there is

Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-25 Thread Balbir Singh
On Tue, Nov 24, 2020 at 10:09:55AM +0100, Peter Zijlstra wrote: > On Tue, Nov 24, 2020 at 10:31:49AM +1100, Balbir Singh wrote: > > On Mon, Nov 23, 2020 at 07:31:31AM -0500, Vineeth Pillai wrote: > > > Hi Balbir, > > > > > > On 11/22/20 6:44 AM, Balbir Singh wrote: > > > > > > > > This seems cumb

Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-24 Thread Peter Zijlstra
On Tue, Nov 24, 2020 at 10:31:49AM +1100, Balbir Singh wrote: > On Mon, Nov 23, 2020 at 07:31:31AM -0500, Vineeth Pillai wrote: > > Hi Balbir, > > > > On 11/22/20 6:44 AM, Balbir Singh wrote: > > > > > > This seems cumbersome, is there no way to track the min_vruntime via > > > rq->core->min_vrun

Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-23 Thread Balbir Singh
On Mon, Nov 23, 2020 at 07:31:31AM -0500, Vineeth Pillai wrote: > Hi Balbir, > > On 11/22/20 6:44 AM, Balbir Singh wrote: > > > > This seems cumbersome, is there no way to track the min_vruntime via > > rq->core->min_vruntime? > Do you mean to have a core wide min_vruntime? We had a > similar app

Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-23 Thread Vineeth Pillai
Hi Balbir, On 11/22/20 6:44 AM, Balbir Singh wrote: This seems cumbersome, is there no way to track the min_vruntime via rq->core->min_vruntime? Do you mean to have a core wide min_vruntime? We had a similar approach from v3 to v7 and it had major issues which broke the assumptions of cfs. The

Re: [PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-22 Thread Balbir Singh
On Tue, Nov 17, 2020 at 06:19:39PM -0500, Joel Fernandes (Google) wrote: > During force-idle, we end up doing cross-cpu comparison of vruntimes > during pick_next_task. If we simply compare (vruntime-min_vruntime) > across CPUs, and if the CPUs only have 1 task each, we will always > end up compari

[PATCH -tip 09/32] sched/fair: Snapshot the min_vruntime of CPUs on force idle

2020-11-17 Thread Joel Fernandes (Google)
During force-idle, we end up doing cross-cpu comparison of vruntimes during pick_next_task. If we simply compare (vruntime-min_vruntime) across CPUs, and if the CPUs only have 1 task each, we will always end up comparing 0 with 0 and pick just one of the tasks all the time. This starves the task th