Re: [PATCH -tip 3/5] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler()

2021-03-11 Thread Masami Hiramatsu
Hi Miroslav, On Thu, 11 Mar 2021 00:42:25 +0900 Masami Hiramatsu wrote: > > > + */ > > > +static nokprobe_inline void *kretprobe_trampoline_addr(void) > > > +{ > > > + return dereference_function_descriptor(kretprobe_trampoline); > > > +} > > > + > > > > Would it make sense to use this in s390

Re: [PATCH -tip 3/5] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler()

2021-03-10 Thread Masami Hiramatsu
On Wed, 10 Mar 2021 15:21:01 +0100 (CET) Miroslav Benes wrote: > Hi Masami, > > > --- a/include/linux/kprobes.h > > +++ b/include/linux/kprobes.h > > @@ -205,15 +205,23 @@ extern void arch_prepare_kretprobe(struct > > kretprobe_instance *ri, > >struct pt_regs

Re: [PATCH -tip 3/5] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler()

2021-03-10 Thread Miroslav Benes
Hi Masami, > --- a/include/linux/kprobes.h > +++ b/include/linux/kprobes.h > @@ -205,15 +205,23 @@ extern void arch_prepare_kretprobe(struct > kretprobe_instance *ri, > struct pt_regs *regs); > extern int arch_trampoline_kprobe(struct kprobe *p); > > +void

[PATCH -tip 3/5] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler()

2021-03-05 Thread Masami Hiramatsu
Remove trampoline_address from kretprobe_trampoline_handler(). Instead of passing the address, kretprobe_trampoline_handler() can use new kretprobe_trampoline_addr(). Signed-off-by: Masami Hiramatsu --- arch/arc/kernel/kprobes.c |2 +- arch/arm/probes/kprobes/core.c |3 +--