Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-05 Thread Peter Zijlstra
On Tue, Jan 05, 2021 at 04:23:44PM +0800, Lai Jiangshan wrote: > Even with the help of wq_online_cpumask, the patchset can't silence > the warning in __set_cpus_allowed_ptr() in this case. It is indeed > hard to suppress the warning for unbound pools. Maybe we need something

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-05 Thread Lai Jiangshan
On Tue, Jan 5, 2021 at 10:37 PM Lai Jiangshan wrote: > > On Tue, Jan 5, 2021 at 9:17 PM Peter Zijlstra wrote: > > > > On Tue, Jan 05, 2021 at 04:23:44PM +0800, Lai Jiangshan wrote: > > > On Tue, Jan 5, 2021 at 10:41 AM Lai Jiangshan > > > wrote: > > > > On Mon, Jan 4, 2021 at 9:56 PM Peter

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-05 Thread Lai Jiangshan
On Tue, Jan 5, 2021 at 9:17 PM Peter Zijlstra wrote: > > On Tue, Jan 05, 2021 at 04:23:44PM +0800, Lai Jiangshan wrote: > > On Tue, Jan 5, 2021 at 10:41 AM Lai Jiangshan > > wrote: > > > On Mon, Jan 4, 2021 at 9:56 PM Peter Zijlstra > > > wrote: > > > > On Sat, Dec 26, 2020 at 10:51:11AM

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-05 Thread Peter Zijlstra
On Tue, Jan 05, 2021 at 04:23:44PM +0800, Lai Jiangshan wrote: > On Tue, Jan 5, 2021 at 10:41 AM Lai Jiangshan wrote: > > On Mon, Jan 4, 2021 at 9:56 PM Peter Zijlstra wrote: > > > On Sat, Dec 26, 2020 at 10:51:11AM +0800, Lai Jiangshan wrote: > > > > From: Lai Jiangshan > > > > > > > >

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-05 Thread Lai Jiangshan
On Tue, Jan 5, 2021 at 10:41 AM Lai Jiangshan wrote: > > On Mon, Jan 4, 2021 at 9:56 PM Peter Zijlstra wrote: > > > > On Sat, Dec 26, 2020 at 10:51:11AM +0800, Lai Jiangshan wrote: > > > From: Lai Jiangshan > > > > > > wq_online_cpumask is the cached result of cpu_online_mask with the > > >

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-04 Thread Lai Jiangshan
On Tue, Jan 5, 2021 at 10:41 AM Lai Jiangshan wrote: > > On Mon, Jan 4, 2021 at 9:56 PM Peter Zijlstra wrote: > > > > On Sat, Dec 26, 2020 at 10:51:11AM +0800, Lai Jiangshan wrote: > > > From: Lai Jiangshan > > > > > > wq_online_cpumask is the cached result of cpu_online_mask with the > > >

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-04 Thread Lai Jiangshan
On Mon, Jan 4, 2021 at 9:56 PM Peter Zijlstra wrote: > > On Sat, Dec 26, 2020 at 10:51:11AM +0800, Lai Jiangshan wrote: > > From: Lai Jiangshan > > > > wq_online_cpumask is the cached result of cpu_online_mask with the > > going-down cpu cleared. > > You can't use cpu_active_mask ? When a cpu

Re: [PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2021-01-04 Thread Peter Zijlstra
On Sat, Dec 26, 2020 at 10:51:11AM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan > > wq_online_cpumask is the cached result of cpu_online_mask with the > going-down cpu cleared. You can't use cpu_active_mask ?

[PATCH -tip V3 3/8] workqueue: introduce wq_online_cpumask

2020-12-25 Thread Lai Jiangshan
From: Lai Jiangshan wq_online_cpumask is the cached result of cpu_online_mask with the going-down cpu cleared. It is needed for later patches for setting correct cpumask for workers and break affinity initiatively. The first usage of wq_online_cpumask is also in this patch.