Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-27 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 27, 2013 at 02:49:02PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Dec 27, 2013 at 09:20:11AM -0500, David Ahern escreveu: > > On 12/27/13, 1:14 AM, Masami Hiramatsu wrote: > > >Nowhere, since there is no terminal code for user > > >command interface. > > > >Those memories are

Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-27 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 27, 2013 at 09:20:11AM -0500, David Ahern escreveu: > On 12/27/13, 1:14 AM, Masami Hiramatsu wrote: > >Nowhere, since there is no terminal code for user > >command interface. > >Those memories are released when the program terminated. > >I think it is just a waste of the time to free t

Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-27 Thread David Ahern
On 12/27/13, 1:14 AM, Masami Hiramatsu wrote: Nowhere, since there is no terminal code for user command interface. Those memories are released when the program terminated. I think it is just a waste of the time to free the memory pieces which are not used(and allocated) repeatedly. Or, is there

Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-26 Thread Masami Hiramatsu
(2013/12/26 23:22), Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 26, 2013 at 09:14:46AM -0500, David Ahern escreveu: >> On 12/26/13, 12:41 AM, Masami Hiramatsu wrote: >>> @@ -180,7 +181,20 @@ static int opt_set_target(const struct option *opt, >>> const char *str, >>> else >>>

Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-26 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 26, 2013 at 09:14:46AM -0500, David Ahern escreveu: > On 12/26/13, 12:41 AM, Masami Hiramatsu wrote: > >@@ -180,7 +181,20 @@ static int opt_set_target(const struct option *opt, > >const char *str, > > else > > return ret; > > > >-params.targe

Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-26 Thread David Ahern
On 12/26/13, 12:41 AM, Masami Hiramatsu wrote: @@ -180,7 +181,20 @@ static int opt_set_target(const struct option *opt, const char *str, else return ret; - params.target = str; + /* Expand given path to absolute path, except fo

[PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-25 Thread Masami Hiramatsu
Expand given path to absolute path in the option parser, except for a module name. Since realpath at later stage in processing several probe point, can be called several times(even if currently doesn't, it can happen when we expands the feature), it is waste of the performance. Processing it once