Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Steven Rostedt
On Wed, 6 Nov 2013 07:07:37 +0100 Ingo Molnar wrote: > So until compilers get smarter (or there's some compiler trick I haven't > noticed) lets stay with the separate section - it's not the end of the > world, the (effective) 'noinline' aspect of noprobes changes code > generation anyway. >

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Ingo Molnar
* Masami Hiramatsu wrote: > (2013/11/06 15:07), Ingo Molnar wrote: > > > > * Masami Hiramatsu wrote: > > > [...] I hope to build the list when the kernel build time if > possible... Would you have any idea to classify some annotated(but no > side-effect) functions? > >>> >

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Masami Hiramatsu
(2013/11/06 15:07), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > [...] I hope to build the list when the kernel build time if possible... Would you have any idea to classify some annotated(but no side-effect) functions? >>> >>> The macro magic I can think of would need to

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Masami Hiramatsu
(2013/11/06 15:07), Ingo Molnar wrote: * Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] I hope to build the list when the kernel build time if possible... Would you have any idea to classify some annotated(but no side-effect) functions? The macro magic I can think of

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Ingo Molnar
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2013/11/06 15:07), Ingo Molnar wrote: * Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] I hope to build the list when the kernel build time if possible... Would you have any idea to classify some annotated(but

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-06 Thread Steven Rostedt
On Wed, 6 Nov 2013 07:07:37 +0100 Ingo Molnar mi...@kernel.org wrote: So until compilers get smarter (or there's some compiler trick I haven't noticed) lets stay with the separate section - it's not the end of the world, the (effective) 'noinline' aspect of noprobes changes code

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Ingo Molnar
* Masami Hiramatsu wrote: > >> [...] I hope to build the list when the kernel build time if > >> possible... Would you have any idea to classify some annotated(but no > >> side-effect) functions? > > > > The macro magic I can think of would need to change the syntax of the > > function

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Steven Rostedt
On Tue, 5 Nov 2013 08:05:37 +0100 Ingo Molnar wrote: > The macro magic I can think of would need to change the syntax of the > function definition - for example that is how the SYSCALL_DEFINE*() macros > work. Or something like the EXPORT_SYMBOL(), but that wouldn't include the size of the

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Masami Hiramatsu
(2013/11/05 20:38), Masami Hiramatsu wrote: > (2013/11/05 16:05), Ingo Molnar wrote: >> >> * Masami Hiramatsu wrote: >> >>> (2013/11/05 15:09), Ingo Molnar wrote: * Steven Rostedt wrote: > On Fri, 01 Nov 2013 11:25:37 + > Masami Hiramatsu wrote: > >> Prohibit

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Masami Hiramatsu
(2013/11/05 16:05), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2013/11/05 15:09), Ingo Molnar wrote: >>> >>> * Steven Rostedt wrote: >>> On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu wrote: > Prohibit probing on func_ptr_is_kernel_text(). > Since the

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Masami Hiramatsu
(2013/11/05 16:05), Ingo Molnar wrote: * Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2013/11/05 15:09), Ingo Molnar wrote: * Steven Rostedt rost...@goodmis.org wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Masami Hiramatsu
(2013/11/05 20:38), Masami Hiramatsu wrote: (2013/11/05 16:05), Ingo Molnar wrote: * Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2013/11/05 15:09), Ingo Molnar wrote: * Steven Rostedt rost...@goodmis.org wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Steven Rostedt
On Tue, 5 Nov 2013 08:05:37 +0100 Ingo Molnar mi...@kernel.org wrote: The macro magic I can think of would need to change the syntax of the function definition - for example that is how the SYSCALL_DEFINE*() macros work. Or something like the EXPORT_SYMBOL(), but that wouldn't include the

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-05 Thread Ingo Molnar
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] I hope to build the list when the kernel build time if possible... Would you have any idea to classify some annotated(but no side-effect) functions? The macro magic I can think of would need to change the syntax of the

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Ingo Molnar
* Masami Hiramatsu wrote: > (2013/11/05 15:09), Ingo Molnar wrote: > > > > * Steven Rostedt wrote: > > > >> On Fri, 01 Nov 2013 11:25:37 + > >> Masami Hiramatsu wrote: > >> > >>> Prohibit probing on func_ptr_is_kernel_text(). > >>> Since the func_ptr_is_kernel_text() is called from >

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Masami Hiramatsu
(2013/11/05 15:09), Ingo Molnar wrote: > > * Steven Rostedt wrote: > >> On Fri, 01 Nov 2013 11:25:37 + >> Masami Hiramatsu wrote: >> >>> Prohibit probing on func_ptr_is_kernel_text(). >>> Since the func_ptr_is_kernel_text() is called from >>> notifier_call_chain() which is called from int3

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Ingo Molnar
* Steven Rostedt wrote: > On Fri, 01 Nov 2013 11:25:37 + > Masami Hiramatsu wrote: > > > Prohibit probing on func_ptr_is_kernel_text(). > > Since the func_ptr_is_kernel_text() is called from > > notifier_call_chain() which is called from int3 handler, > > probing it may cause double int3

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Masami Hiramatsu
(2013/11/05 11:00), Steven Rostedt wrote: > On Fri, 01 Nov 2013 11:25:37 + > Masami Hiramatsu wrote: > >> Prohibit probing on func_ptr_is_kernel_text(). >> Since the func_ptr_is_kernel_text() is called from >> notifier_call_chain() which is called from int3 handler, >> probing it may cause

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Steven Rostedt
On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu wrote: > Prohibit probing on func_ptr_is_kernel_text(). > Since the func_ptr_is_kernel_text() is called from > notifier_call_chain() which is called from int3 handler, > probing it may cause double int3 fault and kernel will > reboot. > > This

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Steven Rostedt
On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3 handler, probing it may cause double int3 fault and

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Masami Hiramatsu
(2013/11/05 11:00), Steven Rostedt wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3 handler,

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Ingo Molnar
* Steven Rostedt rost...@goodmis.org wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Masami Hiramatsu
(2013/11/05 15:09), Ingo Molnar wrote: * Steven Rostedt rost...@goodmis.org wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-04 Thread Ingo Molnar
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2013/11/05 15:09), Ingo Molnar wrote: * Steven Rostedt rost...@goodmis.org wrote: On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text().

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-01 Thread Steven Rostedt
On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu wrote: > Prohibit probing on func_ptr_is_kernel_text(). > Since the func_ptr_is_kernel_text() is called from > notifier_call_chain() which is called from int3 handler, > probing it may cause double int3 fault and kernel will > reboot. > > This

[PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-01 Thread Masami Hiramatsu
Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3 handler, probing it may cause double int3 fault and kernel will reboot. This happenes when the kernel built with CONFIG_DEBUG_NOTIFIERS=y.

[PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-01 Thread Masami Hiramatsu
Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3 handler, probing it may cause double int3 fault and kernel will reboot. This happenes when the kernel built with CONFIG_DEBUG_NOTIFIERS=y.

Re: [PATCH -tip v2 3/3] [BUGFIX] kprobes: Prohibit probing on func_ptr_is_kernel_text

2013-11-01 Thread Steven Rostedt
On Fri, 01 Nov 2013 11:25:37 + Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Prohibit probing on func_ptr_is_kernel_text(). Since the func_ptr_is_kernel_text() is called from notifier_call_chain() which is called from int3 handler, probing it may cause double int3 fault and