Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 07:54:31PM +0530, Vineet Gupta wrote: > On Wednesday 08 June 2016 07:02 PM, Peter Zijlstra wrote: > > On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > > > >> I'd much prefer to have all of these in the locking tree (i.e. > >> tip:locking/core), > >> to make

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 07:54:31PM +0530, Vineet Gupta wrote: > On Wednesday 08 June 2016 07:02 PM, Peter Zijlstra wrote: > > On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > > > >> I'd much prefer to have all of these in the locking tree (i.e. > >> tip:locking/core), > >> to make

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Vineet Gupta
On Wednesday 08 June 2016 07:02 PM, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > >> I'd much prefer to have all of these in the locking tree (i.e. >> tip:locking/core), >> to make it less painful all around. > > All the fetch_op stuff, yes certainly.

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Vineet Gupta
On Wednesday 08 June 2016 07:02 PM, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > >> I'd much prefer to have all of these in the locking tree (i.e. >> tip:locking/core), >> to make it less painful all around. > > All the fetch_op stuff, yes certainly.

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > I'd much prefer to have all of these in the locking tree (i.e. > tip:locking/core), > to make it less painful all around. All the fetch_op stuff, yes certainly. But Vineet wanted to munge arch/arc/include/asm/atomic.h a bit in 4.7,

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 02:55:30PM +0200, Ingo Molnar wrote: > I'd much prefer to have all of these in the locking tree (i.e. > tip:locking/core), > to make it less painful all around. All the fetch_op stuff, yes certainly. But Vineet wanted to munge arch/arc/include/asm/atomic.h a bit in 4.7,

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Jun 02, 2016 at 11:33:04AM +0200, Peter Zijlstra wrote: > > On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > > > > What's ur merge plan - are u going to rebase/respin once more so I can > > > push those > > > updates to

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Jun 02, 2016 at 11:33:04AM +0200, Peter Zijlstra wrote: > > On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > > > > What's ur merge plan - are u going to rebase/respin once more so I can > > > push those > > > updates to Linus for 4.7-rc2. Or

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 11:33:04AM +0200, Peter Zijlstra wrote: > On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > > What's ur merge plan - are u going to rebase/respin once more so I can push > > those > > updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-08 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 11:33:04AM +0200, Peter Zijlstra wrote: > On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > > What's ur merge plan - are u going to rebase/respin once more so I can push > > those > > updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > > Notes: > > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would > >recommend a restructure or split of that file, but could not find > >the will to do

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-02 Thread Peter Zijlstra
On Thu, Jun 02, 2016 at 09:27:36AM +, Vineet Gupta wrote: > On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > > Notes: > > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would > >recommend a restructure or split of that file, but could not find > >the will to do

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-02 Thread Vineet Gupta
On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > Notes: > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would >recommend a restructure or split of that file, but could not find >the will to do it. > - arc, metag and tile could convert to _relaxed. Yes that was

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-02 Thread Vineet Gupta
On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > Notes: > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would >recommend a restructure or split of that file, but could not find >the will to do it. > - arc, metag and tile could convert to _relaxed. Yes that was

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-01 Thread Will Deacon
On Tue, May 31, 2016 at 12:19:25PM +0200, Peter Zijlstra wrote: > As there have been a few requests for atomic_fetch_$op primitives and recently > by Linus, I figured I'd go and implement the lot. > > The atomic_fetch_$op differs from the existing atomic_$op_return we already > have by returning

Re: [PATCH -v2 00/33] implement atomic_fetch_$op

2016-06-01 Thread Will Deacon
On Tue, May 31, 2016 at 12:19:25PM +0200, Peter Zijlstra wrote: > As there have been a few requests for atomic_fetch_$op primitives and recently > by Linus, I figured I'd go and implement the lot. > > The atomic_fetch_$op differs from the existing atomic_$op_return we already > have by returning

[PATCH -v2 00/33] implement atomic_fetch_$op

2016-05-31 Thread Peter Zijlstra
As there have been a few requests for atomic_fetch_$op primitives and recently by Linus, I figured I'd go and implement the lot. The atomic_fetch_$op differs from the existing atomic_$op_return we already have by returning the old value instead of the new value. This is especially useful when the

[PATCH -v2 00/33] implement atomic_fetch_$op

2016-05-31 Thread Peter Zijlstra
As there have been a few requests for atomic_fetch_$op primitives and recently by Linus, I figured I'd go and implement the lot. The atomic_fetch_$op differs from the existing atomic_$op_return we already have by returning the old value instead of the new value. This is especially useful when the