Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-29 Thread Morten Rasmussen
On Fri, Sep 29, 2017 at 01:35:00PM +0200, Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 11:03:03AM +0100, Morten Rasmussen wrote: > > IIUC, if grq->avg.load_avg > grq->load.weight, i.e. you have blocked > > tasks, you can end up with underestimating the ge->load.weight for some > > of the group

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-29 Thread Morten Rasmussen
On Fri, Sep 29, 2017 at 01:35:00PM +0200, Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 11:03:03AM +0100, Morten Rasmussen wrote: > > IIUC, if grq->avg.load_avg > grq->load.weight, i.e. you have blocked > > tasks, you can end up with underestimating the ge->load.weight for some > > of the group

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-29 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 11:03:03AM +0100, Morten Rasmussen wrote: > > +/* > > + * All this does is approximate the hierarchical proportion which includes > > that > > + * global sum we all love to hate. > > + * > > + * That is, the weight of a group entity, is the proportional share of the > > +

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-29 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 11:03:03AM +0100, Morten Rasmussen wrote: > > +/* > > + * All this does is approximate the hierarchical proportion which includes > > that > > + * global sum we all love to hate. > > + * > > + * That is, the weight of a group entity, is the proportional share of the > > +

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-28 Thread Morten Rasmussen
On Fri, Sep 01, 2017 at 03:21:01PM +0200, Peter Zijlstra wrote: > Explain the magic equation in calc_cfs_shares() a bit better. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/fair.c | 61 > > 1 file

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-28 Thread Morten Rasmussen
On Fri, Sep 01, 2017 at 03:21:01PM +0200, Peter Zijlstra wrote: > Explain the magic equation in calc_cfs_shares() a bit better. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/fair.c | 61 > > 1 file changed, 61

[PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-01 Thread Peter Zijlstra
Explain the magic equation in calc_cfs_shares() a bit better. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 61 1 file changed, 61 insertions(+) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@

[PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

2017-09-01 Thread Peter Zijlstra
Explain the magic equation in calc_cfs_shares() a bit better. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/fair.c | 61 1 file changed, 61 insertions(+) --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2707,6 +2707,67 @@