Re: [PATCH -v2 04/18] sched/fair: Remove se->load.weight from se->avg.load_sum

2017-09-29 Thread Peter Zijlstra
On Fri, Sep 29, 2017 at 04:26:10PM +0100, Morten Rasmussen wrote: > On Fri, Sep 01, 2017 at 03:21:03PM +0200, Peter Zijlstra wrote: > > +/* > > + * sched_entity: > > + * > > + * load_sum := runnable_sum > > + * load_avg = se_weight(se) * runnable_avg > > + * > > + * cfq_rs: > > I think this sh

Re: [PATCH -v2 04/18] sched/fair: Remove se->load.weight from se->avg.load_sum

2017-09-29 Thread Morten Rasmussen
On Fri, Sep 01, 2017 at 03:21:03PM +0200, Peter Zijlstra wrote: > +/* > + * sched_entity: > + * > + * load_sum := runnable_sum > + * load_avg = se_weight(se) * runnable_avg > + * > + * cfq_rs: I think this should be "cfs_rq" instead. > + * > + * load_sum = \Sum se_weight(se) * se->avg.load_

[PATCH -v2 04/18] sched/fair: Remove se->load.weight from se->avg.load_sum

2017-09-01 Thread Peter Zijlstra
Remove the load from the load_sum for sched_entities, basically turning load_sum into runnable_sum. This prepares for better reweighting of group entities. Since we now have different rules for computing load_avg, split ___update_load_avg() into two parts, ___update_load_sum() and ___update_load_