Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Mon, Sep 3, 2012 at 12:18 AM, Yinghai Lu wrote: > On Sun, Sep 2, 2012 at 11:26 PM, Pekka Enberg wrote: >> >> Yup, or move the globals together with the comment to arch/x86/mm/init.c. >> >> That said, max_pfn_high_mapped really ought to be kept together with >> the other "pfn_mapped" globals

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Sun, Sep 2, 2012 at 11:26 PM, Pekka Enberg wrote: > > Yup, or move the globals together with the comment to arch/x86/mm/init.c. > > That said, max_pfn_high_mapped really ought to be kept together with > the other "pfn_mapped" globals and the comment should be updated. max_pfn_high_mapped is

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Pekka Enberg
On Mon, Sep 3, 2012 at 9:17 AM, Yinghai Lu wrote: > On Sun, Sep 2, 2012 at 10:50 PM, Pekka Enberg wrote: >> On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu wrote: >>> This one intend to fix bugs: >>> when efi booting have too many memmap entries, will need to double memblock >>> memory array or

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Sun, Sep 2, 2012 at 10:50 PM, Pekka Enberg wrote: > On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu wrote: >> This one intend to fix bugs: >> when efi booting have too many memmap entries, will need to double memblock >> memory array or reserved array. > > Okay, why do we need to do that?

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Sun, Sep 2, 2012 at 10:50 PM, Pekka Enberg penb...@kernel.org wrote: On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu ying...@kernel.org wrote: This one intend to fix bugs: when efi booting have too many memmap entries, will need to double memblock memory array or reserved array. Okay, why do

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Pekka Enberg
On Mon, Sep 3, 2012 at 9:17 AM, Yinghai Lu ying...@kernel.org wrote: On Sun, Sep 2, 2012 at 10:50 PM, Pekka Enberg penb...@kernel.org wrote: On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu ying...@kernel.org wrote: This one intend to fix bugs: when efi booting have too many memmap entries, will

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Sun, Sep 2, 2012 at 11:26 PM, Pekka Enberg penb...@kernel.org wrote: Yup, or move the globals together with the comment to arch/x86/mm/init.c. That said, max_pfn_high_mapped really ought to be kept together with the other pfn_mapped globals and the comment should be updated.

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-03 Thread Yinghai Lu
On Mon, Sep 3, 2012 at 12:18 AM, Yinghai Lu ying...@kernel.org wrote: On Sun, Sep 2, 2012 at 11:26 PM, Pekka Enberg penb...@kernel.org wrote: Yup, or move the globals together with the comment to arch/x86/mm/init.c. That said, max_pfn_high_mapped really ought to be kept together with the

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-02 Thread Pekka Enberg
On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu wrote: > This one intend to fix bugs: > when efi booting have too many memmap entries, will need to double memblock > memory array or reserved array. Okay, why do we need to do that? > +RESERVE_BRK(early_pgt_alloc, 65536); What is this needed for? >

[PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-02 Thread Yinghai Lu
This one intend to fix bugs: when efi booting have too many memmap entries, will need to double memblock memory array or reserved array. For 64bit, We have low kernel mapping, and high kernel mapping. high kernel mapping is done early in head_64.S. low kernel mapping is done in

[PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-02 Thread Yinghai Lu
This one intend to fix bugs: when efi booting have too many memmap entries, will need to double memblock memory array or reserved array. For 64bit, We have low kernel mapping, and high kernel mapping. high kernel mapping is done early in head_64.S. low kernel mapping is done in

Re: [PATCH -v2 13/13] x86, 64bit: Map first 1M ram early before memblock_x86_fill()

2012-09-02 Thread Pekka Enberg
On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu ying...@kernel.org wrote: This one intend to fix bugs: when efi booting have too many memmap entries, will need to double memblock memory array or reserved array. Okay, why do we need to do that? +RESERVE_BRK(early_pgt_alloc, 65536); What is this