Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-27 Thread Borislav Petkov
On Sat, Jan 26, 2013 at 05:26:40PM -0800, H. Peter Anvin wrote: > Out-of-tree code is responsible for keeping up, not the other way around. Ok, this actually a "doh, Boris, of course". If code wants to work with linux, it should be upstream in the first place. Otherwise, it has to keep up. Cool.

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-27 Thread Borislav Petkov
On Sat, Jan 26, 2013 at 05:26:40PM -0800, H. Peter Anvin wrote: Out-of-tree code is responsible for keeping up, not the other way around. Ok, this actually a doh, Boris, of course. If code wants to work with linux, it should be upstream in the first place. Otherwise, it has to keep up. Cool. --

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-26 Thread H. Peter Anvin
On 01/25/2013 10:43 AM, Borislav Petkov wrote: On Fri, Jan 25, 2013 at 07:35:07PM +0100, Borislav Petkov wrote: Ok, if you prefer. We can definitely make all .o's which depend on x86_hyper also depend on CONFIG_HYPERVISOR_GUEST - this solves the whole deal trivially. I'll respin the patches.

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-26 Thread H. Peter Anvin
On 01/25/2013 10:43 AM, Borislav Petkov wrote: On Fri, Jan 25, 2013 at 07:35:07PM +0100, Borislav Petkov wrote: Ok, if you prefer. We can definitely make all .o's which depend on x86_hyper also depend on CONFIG_HYPERVISOR_GUEST - this solves the whole deal trivially. I'll respin the patches.

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:42:32AM -0800, Dmitry Torokhov wrote: > No, not really as EXPORT_SYMBOL_GPL() in no way implies that the code > using it lives in the mainline. I didn't say that - I said "any code (proprietary included) can link to those symbols" meaning that I cannot possibly convert

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:32:13PM +0100, Borislav Petkov wrote: > On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote: > > Hi Borislav, > > > > On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > > > From: Borislav Petkov > > > > > > Put all config options needed to

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 07:35:07PM +0100, Borislav Petkov wrote: > Ok, if you prefer. We can definitely make all .o's which depend on > x86_hyper also depend on CONFIG_HYPERVISOR_GUEST - this solves the > whole deal trivially. > > I'll respin the patches. ... provided, of course, nothing

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:29:25AM -0800, Dmitry Torokhov wrote: > Can't we make the balloon driver depend on CONFIG_HYPERVISOR_GUEST? We certainly can do that, AFAICT. > We do not _need_ more and have no plans to introduce new ones AFAIK, > but I think that comparing an address of a structure

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:23:35PM +0100, Borislav Petkov wrote: > On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote: > > > - if (x86_hyper != _hyper_ms_hyperv) > > > + if (!x86_hyper || strncmp(x86_hyper->name, "VMware", 6)) > > > return -ENODEV; > > > > I assume this is

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote: > Hi Borislav, > > On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > > From: Borislav Petkov > > > > Put all config options needed to run Linux as a guest behind a > > CONFIG_HYPERVISOR_GUEST menu so that they

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote: > > - if (x86_hyper != _hyper_ms_hyperv) > > + if (!x86_hyper || strncmp(x86_hyper->name, "VMware", 6)) > > return -ENODEV; > > I assume this is a typo as I doubt MS is using the same signature as we > do. Yeah,

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Put all config options needed to run Linux as a guest behind a > CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by > default but selected by the user. Also, move x86_hyper

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 8e1a9ec53003..cb467656e684 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -724,7 +724,7 @@ static int __init

[PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
From: Borislav Petkov Put all config options needed to run Linux as a guest behind a CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by default but selected by the user. Also, move x86_hyper into an unconditionally-built compilation unit because it is exported with the non-GPL

[PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
From: Borislav Petkov b...@suse.de Put all config options needed to run Linux as a guest behind a CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by default but selected by the user. Also, move x86_hyper into an unconditionally-built compilation unit because it is exported with the

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 8e1a9ec53003..cb467656e684 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -724,7 +724,7 @@ static int __init

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Put all config options needed to run Linux as a guest behind a CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by default but selected by the user. Also, move

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote: - if (x86_hyper != x86_hyper_ms_hyperv) + if (!x86_hyper || strncmp(x86_hyper-name, VMware, 6)) return -ENODEV; I assume this is a typo as I doubt MS is using the same signature as we do. Yeah, Vmware is

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:23:35PM +0100, Borislav Petkov wrote: On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote: - if (x86_hyper != x86_hyper_ms_hyperv) + if (!x86_hyper || strncmp(x86_hyper-name, VMware, 6)) return -ENODEV; I assume this is a typo as I

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote: Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Put all config options needed to run Linux as a guest behind a CONFIG_HYPERVISOR_GUEST menu so that they

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:29:25AM -0800, Dmitry Torokhov wrote: Can't we make the balloon driver depend on CONFIG_HYPERVISOR_GUEST? We certainly can do that, AFAICT. We do not _need_ more and have no plans to introduce new ones AFAIK, but I think that comparing an address of a structure

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 07:35:07PM +0100, Borislav Petkov wrote: Ok, if you prefer. We can definitely make all .o's which depend on x86_hyper also depend on CONFIG_HYPERVISOR_GUEST - this solves the whole deal trivially. I'll respin the patches. ... provided, of course, nothing out-of-tree

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Dmitry Torokhov
On Fri, Jan 25, 2013 at 07:32:13PM +0100, Borislav Petkov wrote: On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote: Hi Borislav, On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Put all config options needed to run

Re: [PATCH -v2 2/2] x86: Make Linux guest support optional

2013-01-25 Thread Borislav Petkov
On Fri, Jan 25, 2013 at 10:42:32AM -0800, Dmitry Torokhov wrote: No, not really as EXPORT_SYMBOL_GPL() in no way implies that the code using it lives in the mainline. I didn't say that - I said any code (proprietary included) can link to those symbols meaning that I cannot possibly convert