Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Yijing Wang
>> >> Hi Bjorn, >>I'm reworking this patch, but found some strange info about vpd serial >> number. >> I have two x86 machines, they almost have the same hardware topology. But by >> lspci, >> I found two different Broadcom BCM5709 NIC in different machine have the >> same vpd serial >> numb

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 9:46 PM, Yijing Wang wrote: >> I'm not sure this is implemented at the correct place. The idea of >> using the serial number to detect card swaps is not really specific to >> pciehp. I know the Device Serial Number capability is defined in the >> PCIe spec, but it doesn't

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Yijing Wang
> I'm not sure this is implemented at the correct place. The idea of > using the serial number to detect card swaps is not really specific to > pciehp. I know the Device Serial Number capability is defined in the > PCIe spec, but it doesn't *require* any PCIe functionality, and > there's no reaso

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-26 Thread Yijing Wang
Hi Bjorn, Thanks for your review and comments! > > I'm not sure this is implemented at the correct place. The idea of > using the serial number to detect card swaps is not really specific to > pciehp. I know the Device Serial Number capability is defined in the > PCIe spec, but it doesn't *r

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-25 Thread Bjorn Helgaas
On Fri, Jul 12, 2013 at 3:32 AM, Yijing Wang wrote: > If device was removed from slot and reinsert a new device during > suspend, pciehp can not identify the physical device change now. > So the old driver .resume() method will be called for the new device, > this is bad. If device support device

[PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-12 Thread Yijing Wang
If device was removed from slot and reinsert a new device during suspend, pciehp can not identify the physical device change now. So the old driver .resume() method will be called for the new device, this is bad. If device support device serial number capability, we can identify this by DSN. So the