Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-02-08 Thread Takashi Iwai
At Sat, 7 Feb 2015 18:10:48 +0800, Greg Kroah-Hartman wrote: > > On Fri, Jan 30, 2015 at 05:31:51PM +0100, Takashi Iwai wrote: > > If we export device_add_groups() and device_remove_groups(), is it > > safe to call it before device_add()? If yes, some drivers/subsystems > > can have a code flow l

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-02-07 Thread Greg Kroah-Hartman
On Fri, Jan 30, 2015 at 05:31:51PM +0100, Takashi Iwai wrote: > At Thu, 29 Jan 2015 20:26:26 -0800, > Greg Kroah-Hartman wrote: > > > > On Thu, Jan 29, 2015 at 12:11:21AM +0100, Takashi Iwai wrote: > > > At Wed, 28 Jan 2015 14:28:51 -0800, > > > Greg Kroah-Hartman wrote: > > > > > > > > On Wed, J

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-30 Thread Takashi Iwai
At Thu, 29 Jan 2015 20:26:26 -0800, Greg Kroah-Hartman wrote: > > On Thu, Jan 29, 2015 at 12:11:21AM +0100, Takashi Iwai wrote: > > At Wed, 28 Jan 2015 14:28:51 -0800, > > Greg Kroah-Hartman wrote: > > > > > > On Wed, Jan 28, 2015 at 11:18:57PM +0100, Takashi Iwai wrote: > > > > At Wed, 28 Jan 20

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-29 Thread Greg Kroah-Hartman
On Thu, Jan 29, 2015 at 12:11:21AM +0100, Takashi Iwai wrote: > At Wed, 28 Jan 2015 14:28:51 -0800, > Greg Kroah-Hartman wrote: > > > > On Wed, Jan 28, 2015 at 11:18:57PM +0100, Takashi Iwai wrote: > > > At Wed, 28 Jan 2015 13:34:21 -0800, > > > Greg Kroah-Hartman wrote: > > > > > > > > On Wed, J

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Greg Kroah-Hartman
On Wed, Jan 28, 2015 at 10:26:28PM +0100, Takashi Iwai wrote: > At Wed, 28 Jan 2015 13:05:47 -0800, > Greg Kroah-Hartman wrote: > > > > On Wed, Jan 28, 2015 at 09:46:12PM +0100, Takashi Iwai wrote: > > > Hi, > > > > > > this is a simple patch to add device_create_files() and > > > device_remove_f

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Greg Kroah-Hartman
On Wed, Jan 28, 2015 at 09:46:12PM +0100, Takashi Iwai wrote: > Hi, > > this is a simple patch to add device_create_files() and > device_remove_files() to replace multiple device_create_file() or > _remove() calls with a single shot with the device_attr list. > > It's basically just a clean up, b

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Takashi Iwai
At Wed, 28 Jan 2015 13:05:47 -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2015 at 09:46:12PM +0100, Takashi Iwai wrote: > > Hi, > > > > this is a simple patch to add device_create_files() and > > device_remove_files() to replace multiple device_create_file() or > > _remove() calls with a

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Greg Kroah-Hartman
On Wed, Jan 28, 2015 at 11:18:57PM +0100, Takashi Iwai wrote: > At Wed, 28 Jan 2015 13:34:21 -0800, > Greg Kroah-Hartman wrote: > > > > On Wed, Jan 28, 2015 at 10:26:28PM +0100, Takashi Iwai wrote: > > > At Wed, 28 Jan 2015 13:05:47 -0800, > > > Greg Kroah-Hartman wrote: > > > > > > > > On Wed, J

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Takashi Iwai
At Wed, 28 Jan 2015 13:34:21 -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2015 at 10:26:28PM +0100, Takashi Iwai wrote: > > At Wed, 28 Jan 2015 13:05:47 -0800, > > Greg Kroah-Hartman wrote: > > > > > > On Wed, Jan 28, 2015 at 09:46:12PM +0100, Takashi Iwai wrote: > > > > Hi, > > > > > >

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Takashi Iwai
At Wed, 28 Jan 2015 14:28:51 -0800, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2015 at 11:18:57PM +0100, Takashi Iwai wrote: > > At Wed, 28 Jan 2015 13:34:21 -0800, > > Greg Kroah-Hartman wrote: > > > > > > On Wed, Jan 28, 2015 at 10:26:28PM +0100, Takashi Iwai wrote: > > > > At Wed, 28 Jan 20

[PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-01-28 Thread Takashi Iwai
Hi, this is a simple patch to add device_create_files() and device_remove_files() to replace multiple device_create_file() or _remove() calls with a single shot with the device_attr list. It's basically just a clean up, but also helps to simplify the error handling a lot in many existing codes si