Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 01:34:18PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > > > Ah, I missed the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 01:34:18PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > > > Ah, I missed the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > Ah, I missed the "n" in various #ifndef statements. > > > > > > I can't really comment on

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > Ah, I missed the "n" in various #ifndef statements. > > > > > > I can't really comment on

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > Ah, I missed the "n" in various #ifndef statements. > > > > I can't really comment on how to solve that; I simply don't know. > > Also, even with a dt property,

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > Ah, I missed the "n" in various #ifndef statements. > > > > I can't really comment on how to solve that; I simply don't know. > > Also, even with a dt property,

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > Ah, I missed the "n" in various #ifndef statements. > > I can't really comment on how to solve that; I simply don't know. > Also, even with a dt property, it still would be necessary to have > a non-DT means to configure one or the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > Ah, I missed the "n" in various #ifndef statements. > > I can't really comment on how to solve that; I simply don't know. > Also, even with a dt property, it still would be necessary to have > a non-DT means to configure one or the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 06:32:04PM +0200, Alexandre Belloni wrote: > On 25/04/2017 at 09:17:43 -0700, Guenter Roeck wrote: > > On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > > > Hi Guenter, > > > > > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck > > >

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 06:32:04PM +0200, Alexandre Belloni wrote: > On 25/04/2017 at 09:17:43 -0700, Guenter Roeck wrote: > > On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > > > Hi Guenter, > > > > > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck > > > wrote: > > > > On

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Alexandre Belloni
On 25/04/2017 at 09:17:43 -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > > Hi Guenter, > > > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > > > On 04/24/2017 03:05 PM, Moritz Fischer wrote: > > > > >> I'm very

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Alexandre Belloni
On 25/04/2017 at 09:17:43 -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > > Hi Guenter, > > > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > > > On 04/24/2017 03:05 PM, Moritz Fischer wrote: > > > > >> I'm very unhappy with the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > Hi Guenter, > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > > On 04/24/2017 03:05 PM, Moritz Fischer wrote: > > >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling > >> the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Guenter Roeck
On Tue, Apr 25, 2017 at 07:55:28AM -0700, Moritz Fischer wrote: > Hi Guenter, > > On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > > On 04/24/2017 03:05 PM, Moritz Fischer wrote: > > >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling > >> the watchdog behavior and

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
Hi Guenter, On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > On 04/24/2017 03:05 PM, Moritz Fischer wrote: >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling >> the watchdog behavior and currently I'm investigating how to make >> that work via DT.

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
Hi Guenter, On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > On 04/24/2017 03:05 PM, Moritz Fischer wrote: >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling >> the watchdog behavior and currently I'm investigating how to make >> that work via DT. >> >> Watchdog

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Guenter Roeck
On 04/24/2017 03:05 PM, Moritz Fischer wrote: Hi all, this series fixes two issues that I ran into when trying to use the watchdog part of the DS1374 on of our products. This series is basically a precursor to some further cleanup work, that turns the DS1374 into a MFD device with an RTC and

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Guenter Roeck
On 04/24/2017 03:05 PM, Moritz Fischer wrote: Hi all, this series fixes two issues that I ran into when trying to use the watchdog part of the DS1374 on of our products. This series is basically a precursor to some further cleanup work, that turns the DS1374 into a MFD device with an RTC and

[PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Moritz Fischer
Hi all, this series fixes two issues that I ran into when trying to use the watchdog part of the DS1374 on of our products. This series is basically a precursor to some further cleanup work, that turns the DS1374 into a MFD device with an RTC and WDT in separate drivers [1] each integrated in

[PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Moritz Fischer
Hi all, this series fixes two issues that I ran into when trying to use the watchdog part of the DS1374 on of our products. This series is basically a precursor to some further cleanup work, that turns the DS1374 into a MFD device with an RTC and WDT in separate drivers [1] each integrated in