Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-15 Thread Hans de Goede
Hi, On 15-02-19 10:29, Andy Shevchenko wrote: On Fri, Feb 15, 2019 at 10:31 AM Hans de Goede wrote: On 14-02-19 15:15, Yauhen Kharuzhy wrote: I would do something similar with the fuel-gauge in drivers/platform/x86/intel_cht_int33fe.c, one option would be to simply count the number of

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-15 Thread Andy Shevchenko
On Fri, Feb 15, 2019 at 10:31 AM Hans de Goede wrote: > On 14-02-19 15:15, Yauhen Kharuzhy wrote: > I would do something similar with the fuel-gauge in > drivers/platform/x86/intel_cht_int33fe.c, one option would > be to simply count the number of resources in the ACPI > resource table for the

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-15 Thread Hans de Goede
Hi, On 15-02-19 08:01, Yauhen Kharuzhy wrote: On Thu, Feb 14, 2019 at 04:05:26PM +0100, Hans de Goede wrote: I would do something similar with the fuel-gauge in drivers/platform/x86/intel_cht_int33fe.c, one option would be to simply count the number of resources in the ACPI resource table

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-14 Thread Chanwoo Choi
Hi Yauhen, You are missing me on cc list. I didn't know this patchset. On next, please use the get_maintainer script in order to send the correct list. On 19. 2. 11. 오전 5:36, Yauhen Kharuzhy wrote: > At implementation of charging support for Lenovo Yoga Book (Intel Cherry Trail > based with

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-14 Thread Yauhen Kharuzhy
On Thu, Feb 14, 2019 at 04:05:26PM +0100, Hans de Goede wrote: > Hi, > > On 14-02-19 15:15, Yauhen Kharuzhy wrote: > > > > > > чц, 14 лют 2019, 15.47: карыстальнік Andy Shevchenko > > > > напісаў: > > > > On Thu, Feb 14, 2019 at 12:00:44AM +0100,

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-14 Thread Hans de Goede
Hi, On 14-02-19 15:15, Yauhen Kharuzhy wrote: чц, 14 лют 2019, 15.47: карыстальнік Andy Shevchenko mailto:andriy.shevche...@linux.intel.com>> напісаў: On Thu, Feb 14, 2019 at 12:00:44AM +0100, Hans de Goede wrote: > On 10-02-19 21:36, Yauhen Kharuzhy wrote: > A kind request to

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-14 Thread Andy Shevchenko
On Thu, Feb 14, 2019 at 12:00:44AM +0100, Hans de Goede wrote: > On 10-02-19 21:36, Yauhen Kharuzhy wrote: > A kind request to the platform-x86 driver maintainers (hi Andy): Please > do not apply these patches until I've been able to test they don't cause > issues elsewhere. Yes, that's my plan

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-14 Thread Hans de Goede
Hi, On 14-02-19 00:00, Hans de Goede wrote: Hi, On 10-02-19 21:36, Yauhen Kharuzhy wrote: At implementation of charging support for Lenovo Yoga Book (Intel Cherry Trail based with Whiskey Cove PMIC), two pitfalls were found: - for detection of charger type by PMIC, bit 6 in the CHGRCTRL1

Re: [PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-13 Thread Hans de Goede
Hi, On 10-02-19 21:36, Yauhen Kharuzhy wrote: At implementation of charging support for Lenovo Yoga Book (Intel Cherry Trail based with Whiskey Cove PMIC), two pitfalls were found: - for detection of charger type by PMIC, bit 6 in the CHGRCTRL1 register should be set in 0 (and set to 1 for

[PATCH 0/2] extcon: Intel Cherry Trail Whiskey Cove PMIC and external charger tweaks

2019-02-10 Thread Yauhen Kharuzhy
At implementation of charging support for Lenovo Yoga Book (Intel Cherry Trail based with Whiskey Cove PMIC), two pitfalls were found: - for detection of charger type by PMIC, bit 6 in the CHGRCTRL1 register should be set in 0 (and set to 1 for Host mode). Pick up its definition and logic