Ben Hutchings writes:
> On Mon, 2013-06-17 at 11:05 +0930, Rusty Russell wrote:
>> I thought LRO was deprecated and GRO was the new hotness, but I haven't
>> been following. Do we still care about LRO?
>
> The old software LRO implementation, inet_lro, is deprecated in favour
> of GRO and is now
On Mon, 2013-06-17 at 11:05 +0930, Rusty Russell wrote:
> "Michael S. Tsirkin" writes:
> > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote:
> >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
> >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> >> > >
"Michael S. Tsirkin" writes:
> On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote:
>> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
>> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
>> > > From: Ben Hutchings
>> > > Date: Thu, 7 Feb 2013 16:20:46 +
>
On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote:
> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> > > From: Ben Hutchings
> > > Date: Thu, 7 Feb 2013 16:20:46 +
> > >
> > > > If the consensus is st
On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
> On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> > From: Ben Hutchings
> > Date: Thu, 7 Feb 2013 16:20:46 +
> >
> > > If the consensus is still that we must preserve packets exactly (aside
> > > from the usual modif
On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> From: Ben Hutchings
> Date: Thu, 7 Feb 2013 16:20:46 +
>
> > If the consensus is still that we must preserve packets exactly (aside
> > from the usual modifications by IP routers) then LRO should be disabled
> > on all devices fo
From: Ben Hutchings
Date: Thu, 7 Feb 2013 22:31:35 +
> On Thu, 2013-02-07 at 23:33 +0200, Michael S. Tsirkin wrote:
>> We might want to add code to forward LRO status from macvlan
>> (not macvtap) back to the lowerdev, so that setting up forwarding
>> from macvlan disables LRO on the lowerdev
On Thu, 2013-02-07 at 23:33 +0200, Michael S. Tsirkin wrote:
> On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> > From: Ben Hutchings
> > Date: Thu, 7 Feb 2013 16:20:46 +
> >
> > > If the consensus is still that we must preserve packets exactly (aside
> > > from the usual modif
On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> From: Ben Hutchings
> Date: Thu, 7 Feb 2013 16:20:46 +
>
> > If the consensus is still that we must preserve packets exactly (aside
> > from the usual modifications by IP routers) then LRO should be disabled
> > on all devices fo
From: Ben Hutchings
Date: Thu, 7 Feb 2013 16:20:46 +
> If the consensus is still that we must preserve packets exactly (aside
> from the usual modifications by IP routers) then LRO should be disabled
> on all devices for which forwarding is enabled.
I believe this is still undoubtedly the co
On Wed, 2013-02-06 at 19:18 -0800, Eric Dumazet wrote:
> On Wed, 2013-02-06 at 23:34 +, Ben Hutchings wrote:
>
> > If we want to allow forwarding from LRO then net/ipv4/inet_lro.c also
> > needs to set gso_type.
>
> Then, what is dev_disable_lro() purpose ?
The purpose was to disable LRO whe
On Thu, Feb 07, 2013 at 11:25:13AM +0800, Cong Wang wrote:
> On 02/07/2013 07:02 AM, Michael S. Tsirkin wrote:
> >At the moment, macvtap crashes are observed if macvtap is attached
> >to an interface with LRO enabled.
> >The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
> >This happens bec
On 02/07/2013 07:02 AM, Michael S. Tsirkin wrote:
At the moment, macvtap crashes are observed if macvtap is attached
to an interface with LRO enabled.
The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
This happens because several drivers set gso_size but not gso_type
in incoming skbs.
Th
On Wed, 2013-02-06 at 23:34 +, Ben Hutchings wrote:
> If we want to allow forwarding from LRO then net/ipv4/inet_lro.c also
> needs to set gso_type.
Then, what is dev_disable_lro() purpose ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
On Thu, 2013-02-07 at 01:02 +0200, Michael S. Tsirkin wrote:
> At the moment, macvtap crashes are observed if macvtap is attached
> to an interface with LRO enabled.
> The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
> This happens because several drivers set gso_size but not gso_type
> i
At the moment, macvtap crashes are observed if macvtap is attached
to an interface with LRO enabled.
The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
This happens because several drivers set gso_size but not gso_type
in incoming skbs.
The following patches fix this for
Additionally, cbf1d
16 matches
Mail list logo
