Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-03 Thread Oleg Nesterov
On 12/03, Linus Torvalds wrote: > > On Sun, 2 Dec 2007, Oleg Nesterov wrote: > > > > Depends on > > [PATCH] __group_complete_signal: fix coredump with group stop race > > http://marc.info/?l=linux-kernel=119653436116036 > > > > Needs review and testing. > > > > Please comment, I think

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-03 Thread Linus Torvalds
On Sun, 2 Dec 2007, Oleg Nesterov wrote: > > Depends on > [PATCH] __group_complete_signal: fix coredump with group stop race > http://marc.info/?l=linux-kernel=119653436116036 > > Needs review and testing. > > Please comment, I think at least the idea is promising. It looks clean

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-03 Thread Linus Torvalds
On Sun, 2 Dec 2007, Oleg Nesterov wrote: Depends on [PATCH] __group_complete_signal: fix coredump with group stop race http://marc.info/?l=linux-kernelm=119653436116036 Needs review and testing. Please comment, I think at least the idea is promising. It looks clean and

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-03 Thread Oleg Nesterov
On 12/03, Linus Torvalds wrote: On Sun, 2 Dec 2007, Oleg Nesterov wrote: Depends on [PATCH] __group_complete_signal: fix coredump with group stop race http://marc.info/?l=linux-kernelm=119653436116036 Needs review and testing. Please comment, I think at least the idea

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Linus Torvalds
On Sun, 2 Dec 2007, Oleg Nesterov wrote: > > exec() from the signal handler doesn't do sys_sigreturn(), so we don't unblock > the signal, and it remains blocked after exec(). > > Hmm. Is this linux bug, or application bug? I think that's an application bug. The kernel does the obvious (and

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
On 12/02, Simon Holm Th?gersen wrote: > > s??n, 02 12 2007 kl. 20:18 +0300, skrev Oleg Nesterov: > > On 12/02, Simon Holm Th?gersen wrote: > > > > > > I have an issue that sounds related, but I might be completely off. I > > > would expect the simple attached program to keep receiving the same >

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Simon Holm Thøgersen
søn, 02 12 2007 kl. 20:18 +0300, skrev Oleg Nesterov: > On 12/02, Simon Holm Th?gersen wrote: > > > > s??n, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: > > > > > > Please comment, I think at least the idea is promising. > > > > > I have an issue that sounds related, but I might be

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
On 12/02, Simon Holm Th?gersen wrote: > > s??n, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: > > > > Please comment, I think at least the idea is promising. > > > I have an issue that sounds related, but I might be completely off. I > would expect the simple attached program to keep

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Simon Holm Thøgersen
søn, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: > Depends on > [PATCH] __group_complete_signal: fix coredump with group stop race > http://marc.info/?l=linux-kernel=119653436116036 > > Needs review and testing. > > Please comment, I think at least the idea is promising. > I

[PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
Depends on [PATCH] __group_complete_signal: fix coredump with group stop race http://marc.info/?l=linux-kernel=119653436116036 Needs review and testing. Please comment, I think at least the idea is promising. Oleg. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
Depends on [PATCH] __group_complete_signal: fix coredump with group stop race http://marc.info/?l=linux-kernelm=119653436116036 Needs review and testing. Please comment, I think at least the idea is promising. Oleg. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Simon Holm Thøgersen
søn, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: Depends on [PATCH] __group_complete_signal: fix coredump with group stop race http://marc.info/?l=linux-kernelm=119653436116036 Needs review and testing. Please comment, I think at least the idea is promising. I have an

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
On 12/02, Simon Holm Th?gersen wrote: s??n, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: Please comment, I think at least the idea is promising. I have an issue that sounds related, but I might be completely off. I would expect the simple attached program to keep receiving the

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Simon Holm Thøgersen
søn, 02 12 2007 kl. 20:18 +0300, skrev Oleg Nesterov: On 12/02, Simon Holm Th?gersen wrote: s??n, 02 12 2007 kl. 18:14 +0300, skrev Oleg Nesterov: Please comment, I think at least the idea is promising. I have an issue that sounds related, but I might be completely off. I

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Oleg Nesterov
On 12/02, Simon Holm Th?gersen wrote: s??n, 02 12 2007 kl. 20:18 +0300, skrev Oleg Nesterov: On 12/02, Simon Holm Th?gersen wrote: I have an issue that sounds related, but I might be completely off. I would expect the simple attached program to keep receiving the same signal, i.e.

Re: [PATCH 0/2] fix the long standing exec vs kill race

2007-12-02 Thread Linus Torvalds
On Sun, 2 Dec 2007, Oleg Nesterov wrote: exec() from the signal handler doesn't do sys_sigreturn(), so we don't unblock the signal, and it remains blocked after exec(). Hmm. Is this linux bug, or application bug? I think that's an application bug. The kernel does the obvious (and