Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-09-07 Thread Felix Kuehling
ehling, Felix ; >> io...@lists.linux-foundation.org; Huang, Ray ; >> Koenig, Christian ; Lendacky, Thomas >> ; Suthikulpanit, Suravee >> ; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is >> active >> >&g

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-09-07 Thread Christian König
Am 07.09.20 um 12:44 schrieb Joerg Roedel: On Sun, Sep 06, 2020 at 04:08:58PM +, Deucher, Alexander wrote: From f479b9da353c2547c26ebac8930a5dcd9a134eb7 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Sun, 6 Sep 2020 12:05:12 -0400 Subject: [PATCH] drm/amdgpu: Fail to load on RAVEN if

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-09-07 Thread Joerg Roedel
On Sun, Sep 06, 2020 at 04:08:58PM +, Deucher, Alexander wrote: > From f479b9da353c2547c26ebac8930a5dcd9a134eb7 Mon Sep 17 00:00:00 2001 > From: Alex Deucher > Date: Sun, 6 Sep 2020 12:05:12 -0400 > Subject: [PATCH] drm/amdgpu: Fail to load on RAVEN if SME is active > > Due to hardware bugs,

RE: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-09-06 Thread Deucher, Alexander
Christian ; Lendacky, Thomas > ; Suthikulpanit, Suravee > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is > active > > On Fri, Aug 28, 2020 at 03:47:07PM +, Deucher, Alexander wrote: > > Ah, right, So CZ and ST are not an

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-09-04 Thread Joerg Roedel
On Fri, Aug 28, 2020 at 03:47:07PM +, Deucher, Alexander wrote: > Ah, right, So CZ and ST are not an issue. Raven is paired with Zen based > CPUs. Okay, so for the Raven case, can you add code to the amdgpu driver which makes it fail to initialize on Raven when SME is active? There is a

RE: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread Deucher, Alexander
; Suthikulpanit, Suravee > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is > active > > On Fri, Aug 28, 2020 at 03:11:32PM +, Deucher, Alexander wrote: > > There are hw bugs on Raven and probably Carrizo/Stoney where they need

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
On Fri, Aug 28, 2020 at 03:11:32PM +, Deucher, Alexander wrote: > There are hw bugs on Raven and probably Carrizo/Stoney where they need > 1:1 mapping to avoid bugs in some corner cases with the displays. > Other GPUs should be fine. The VIDs is 0x1002 and the DIDs are 0x15dd > and 0x15d8 for

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
Hi Felix, On Fri, Aug 28, 2020 at 09:54:59AM -0400, Felix Kuehling wrote: > Yes, we're working on this. IOMMUv2 is only needed for KFD. It's not > needed for graphics. And we're making it optional for KFD as well. Okay, KFD should fail gracefully because it can't initialize the device's iommuv2

RE: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread Deucher, Alexander
; Suthikulpanit, Suravee > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is > active > > Am 2020-08-28 um 9:46 a.m. schrieb jroe...@suse.de: > > On Wed, Aug 26, 2020 at 03:25:58PM +, Deucher, Alexander wrote: > >>>

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread Felix Kuehling
Am 2020-08-28 um 9:46 a.m. schrieb jroe...@suse.de: > On Wed, Aug 26, 2020 at 03:25:58PM +, Deucher, Alexander wrote: >>> Alex, do you know if anyone has tested amdgpu on an APU with SME >>> enabled? Is this considered something we support? >> It's not something we've tested. I'm not even

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-28 Thread jroe...@suse.de
On Wed, Aug 26, 2020 at 03:25:58PM +, Deucher, Alexander wrote: > > Alex, do you know if anyone has tested amdgpu on an APU with SME > > enabled? Is this considered something we support? > > It's not something we've tested. I'm not even sure the GPU portion of > APUs will work properly

RE: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-26 Thread Deucher, Alexander
ulpanit, Suravee ; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is > active > > [+Ray] > > > Thanks for the heads up. Currently KFD won't work on APUs when IOMMUv2 > is disabled. But Ray is working on fallbacks that wi

Re: [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-26 Thread Felix Kuehling
.@suse.de > ; Lendacky, Thomas ; > Suthikulpanit, Suravee ; Deucher, > Alexander ; linux-kernel@vger.kernel.org > > *Subject:* [PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active >   > From: Joerg Roedel > > Hi, > > Some IOMMUv2 capable devices do not w

[PATCH 0/2] iommu/amd: Fix IOMMUv2 devices when SME is active

2020-08-24 Thread Joerg Roedel
From: Joerg Roedel Hi, Some IOMMUv2 capable devices do not work correctly when SME is active, because their DMA mask does not include the encryption bit, so that they can not DMA to encrypted memory directly. The IOMMU can jump in here, but the AMD IOMMU driver puts IOMMUv2 capable devices