Re: [PATCH 0/2] key payload access with just rcu_read_lock()

om > Sent: Wednesday, 1 March, 2017 10:40:13 AM > Subject: Re: [PATCH 0/2] key payload access with just rcu_read_lock() > > Jan Stancek <jstan...@redhat.com> wrote: > > > That problem didn't show up with my NFS based reproducer. > > I re-run it again with latest v

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > From: "David Howells" > To: "Jan Stancek" > Cc: dhowe...@redhat.com, linux-kernel@vger.kernel.org, > linux-...@vger.kernel.org, bcodd...@redhat.com, > asav...@redhat.com > Sent: Wednesday, 1 March, 2017 10:40:13 AM > Su

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > That problem didn't show up with my NFS based reproducer. > I re-run it again with latest version of your patch, plus also > keyutils testsuite. Both completed OK for me, dmesg looks clean. Can I put you down as a Tested-by? David

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > That problem didn't show up with my NFS based reproducer. > I re-run it again with latest version of your patch, plus also > keyutils testsuite. Both completed OK for me, dmesg looks clean. Can I put you down as a Tested-by? David

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > Here's an updated patch with fixed user_key_payload_locked() and user_read(). > That problem didn't show up with my NFS based reproducer. I re-run it again with latest version of your patch, plus also keyutils testsuite. Both completed OK for me, dmesg looks

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > Here's an updated patch with fixed user_key_payload_locked() and user_read(). > That problem didn't show up with my NFS based reproducer. I re-run it again with latest version of your patch, plus also keyutils testsuite. Both completed OK for me, dmesg looks

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Here's an updated patch with fixed user_key_payload_locked() and user_read(). David --- commit f57350ca3480c418dbc20bf73a7678a7f8e3e4ab Author: David Howells Date: Tue Feb 28 10:08:01 2017 + KEYS: Differentiate uses of rcu_dereference_key() and user_key_payload()

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Here's an updated patch with fixed user_key_payload_locked() and user_read(). David --- commit f57350ca3480c418dbc20bf73a7678a7f8e3e4ab Author: David Howells Date: Tue Feb 28 10:08:01 2017 + KEYS: Differentiate uses of rcu_dereference_key() and user_key_payload()

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > Jan Stancek wrote: > > > Looks like there are still couple users that need updating, > > I'm hitting following compilation error: > > Aargh - I remembered to grep for rcu_dereference_key() but not > user_key_payload(). > > How about the

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > Jan Stancek wrote: > > > Looks like there are still couple users that need updating, > > I'm hitting following compilation error: > > Aargh - I remembered to grep for rcu_dereference_key() but not > user_key_payload(). > > How about the attached? v2 builds OK

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

m > Sent: Monday, 27 February, 2017 11:04:21 PM > Subject: Re: [PATCH 0/2] key payload access with just rcu_read_lock() > > Jan Stancek <jstan...@redhat.com> wrote: > > > this is a follow-up for "suspicious RCU usage" warning described > > in these 2

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

- Original Message - > From: "David Howells" > To: "Jan Stancek" > Cc: dhowe...@redhat.com, linux-kernel@vger.kernel.org, > linux-...@vger.kernel.org, bcodd...@redhat.com, > asav...@redhat.com > Sent: Monday, 27 February, 2017 11:04:21 PM > Su

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > Looks like there are still couple users that need updating, > I'm hitting following compilation error: Aargh - I remembered to grep for rcu_dereference_key() but not user_key_payload(). How about the attached? David --- commit

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > Looks like there are still couple users that need updating, > I'm hitting following compilation error: Aargh - I remembered to grep for rcu_dereference_key() but not user_key_payload(). How about the attached? David --- commit f0268360a253f0f86b9ec538ae3755e187229bbb

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > this is a follow-up for "suspicious RCU usage" warning described > in these 2 linux-nfs threads: > http://marc.info/?t=14755883033=1=2 > http://marc.info/?t=14877677051=1=2 > > Did you have something like in mind? How about the attached?

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Jan Stancek wrote: > this is a follow-up for "suspicious RCU usage" warning described > in these 2 linux-nfs threads: > http://marc.info/?t=14755883033=1=2 > http://marc.info/?t=14877677051=1=2 > > Did you have something like in mind? How about the attached? It's similar to what

[PATCH 0/2] key payload access with just rcu_read_lock()

Hi David, this is a follow-up for "suspicious RCU usage" warning described in these 2 linux-nfs threads: http://marc.info/?t=14755883033=1=2 http://marc.info/?t=14877677051=1=2 Did you have something like in mind? Thanks, Jan Jan Stancek (2): KEYS: add user_key_payload_rcu()

[PATCH 0/2] key payload access with just rcu_read_lock()

Hi David, this is a follow-up for "suspicious RCU usage" warning described in these 2 linux-nfs threads: http://marc.info/?t=14755883033=1=2 http://marc.info/?t=14877677051=1=2 Did you have something like in mind? Thanks, Jan Jan Stancek (2): KEYS: add user_key_payload_rcu()