Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-12 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Oleg Nesterov wrote: > Hi Thomas, > > On 03/11, Thomas Gleixner wrote: > > > > On Mon, 11 Mar 2013, Oleg Nesterov wrote: > > > > > > But the actual reason for this cleanup is that I do not understand > > > why park/unpark abuse kthread.c. > > > > It's not abusing it :) > >

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-12 Thread Oleg Nesterov
Hi Thomas, On 03/11, Thomas Gleixner wrote: > > On Mon, 11 Mar 2013, Oleg Nesterov wrote: > > > > But the actual reason for this cleanup is that I do not understand > > why park/unpark abuse kthread.c. > > It's not abusing it :) Yes, yes, I didn't mean the code looks bad or something like this.

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-12 Thread Oleg Nesterov
Hi Thomas, On 03/11, Thomas Gleixner wrote: On Mon, 11 Mar 2013, Oleg Nesterov wrote: But the actual reason for this cleanup is that I do not understand why park/unpark abuse kthread.c. It's not abusing it :) Yes, yes, I didn't mean the code looks bad or something like this. Just I

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-12 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Oleg Nesterov wrote: Hi Thomas, On 03/11, Thomas Gleixner wrote: On Mon, 11 Mar 2013, Oleg Nesterov wrote: But the actual reason for this cleanup is that I do not understand why park/unpark abuse kthread.c. It's not abusing it :) Yes, yes, I didn't

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-11 Thread Thomas Gleixner
Oleg, On Mon, 11 Mar 2013, Oleg Nesterov wrote: > Imho, task_get_live_kthread() is very confusing and unneeded. > 2a1d4460 copied get_task_struct() + "vfork_done != NULL" from > kthread_stop(), but only kthread_stop() needs them both. > > It needs get_task_struct() because kthread_stop() can be

[PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-11 Thread Oleg Nesterov
Hello. Imho, task_get_live_kthread() is very confusing and unneeded. 2a1d4460 copied get_task_struct() + "vfork_done != NULL" from kthread_stop(), but only kthread_stop() needs them both. It needs get_task_struct() because kthread_stop() can be used when the caller doesn't have a reference but

[PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-11 Thread Oleg Nesterov
Hello. Imho, task_get_live_kthread() is very confusing and unneeded. 2a1d4460 copied get_task_struct() + vfork_done != NULL from kthread_stop(), but only kthread_stop() needs them both. It needs get_task_struct() because kthread_stop() can be used when the caller doesn't have a reference but we

Re: [PATCH 0/2] kthread: kill task_get_live_kthread()

2013-03-11 Thread Thomas Gleixner
Oleg, On Mon, 11 Mar 2013, Oleg Nesterov wrote: Imho, task_get_live_kthread() is very confusing and unneeded. 2a1d4460 copied get_task_struct() + vfork_done != NULL from kthread_stop(), but only kthread_stop() needs them both. It needs get_task_struct() because kthread_stop() can be used