Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Tang Chen
On 04/11/2013 11:10 PM, Yinghai Lu wrote: On Thu, Apr 11, 2013 at 12:41 AM, Tang Chen wrote: 3. If we add flag to memblock, we can mark different memory. And I remember you mentioned before that we can use memblock to reserve local node data for node-life-cycle data, like vmemmap,

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Yinghai Lu
On Thu, Apr 11, 2013 at 12:41 AM, Tang Chen wrote: > > 3. If we add flag to memblock, we can mark different memory. And I remember >you mentioned before that we can use memblock to reserve local node data >for node-life-cycle data, like vmemmap, pagetable. > >So are you doing the

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Tang Chen
Hi Yinghai, (Add cc Liu Jiang.) On 04/09/2013 02:40 AM, Yinghai Lu wrote: On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is broken, and should be fixed. vmemmap should be on local node even for hot add

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Tang Chen
Hi Yinghai, (Add cc Liu Jiang.) On 04/09/2013 02:40 AM, Yinghai Lu wrote: On Mon, Apr 8, 2013 at 2:56 AM, Lin Fenglinf...@cn.fujitsu.com wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is broken, and should be fixed. vmemmap should be on local

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Yinghai Lu
On Thu, Apr 11, 2013 at 12:41 AM, Tang Chen tangc...@cn.fujitsu.com wrote: 3. If we add flag to memblock, we can mark different memory. And I remember you mentioned before that we can use memblock to reserve local node data for node-life-cycle data, like vmemmap, pagetable. So are

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-11 Thread Tang Chen
On 04/11/2013 11:10 PM, Yinghai Lu wrote: On Thu, Apr 11, 2013 at 12:41 AM, Tang Chentangc...@cn.fujitsu.com wrote: 3. If we add flag to memblock, we can mark different memory. And I remember you mentioned before that we can use memblock to reserve local node data for node-life-cycle

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
Hi Yinghai, On 04/09/2013 02:40 AM, Yinghai Lu wrote: > On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng wrote: >> In hot add node(memory) case, vmemmap pages are always allocated from other >> node, > > that is broken, and should be fixed. > vmemmap should be on local node even for hot add node. >

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
Hi Andrew, On 04/09/2013 04:55 AM, Andrew Morton wrote: > On Mon, 8 Apr 2013 11:40:11 -0700 Yinghai Lu wrote: > >> On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng wrote: >>> In hot add node(memory) case, vmemmap pages are always allocated from other >>> node, >> >> that is broken, and should be

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Andrew Morton
On Mon, 8 Apr 2013 11:40:11 -0700 Yinghai Lu wrote: > On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng wrote: > > In hot add node(memory) case, vmemmap pages are always allocated from other > > node, > > that is broken, and should be fixed. > vmemmap should be on local node even for hot add node. >

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Yinghai Lu
On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng wrote: > In hot add node(memory) case, vmemmap pages are always allocated from other > node, that is broken, and should be fixed. vmemmap should be on local node even for hot add node. Thanks Yinghai -- To unsubscribe from this list: send the line

[PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
In hot add node(memory) case, vmemmap pages are always allocated from other node, but the current logic just skip vmemmap_verify check. So we should also issue "potential offnode page_structs" warning messages if we are the case Lin Feng (2): mm: vmemmap: x86: add vmemmap_verify check for

[PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
In hot add node(memory) case, vmemmap pages are always allocated from other node, but the current logic just skip vmemmap_verify check. So we should also issue potential offnode page_structs warning messages if we are the case Lin Feng (2): mm: vmemmap: x86: add vmemmap_verify check for

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Yinghai Lu
On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng linf...@cn.fujitsu.com wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is broken, and should be fixed. vmemmap should be on local node even for hot add node. Thanks Yinghai -- To unsubscribe from this list:

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Andrew Morton
On Mon, 8 Apr 2013 11:40:11 -0700 Yinghai Lu ying...@kernel.org wrote: On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng linf...@cn.fujitsu.com wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is broken, and should be fixed. vmemmap should be on local

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
Hi Andrew, On 04/09/2013 04:55 AM, Andrew Morton wrote: On Mon, 8 Apr 2013 11:40:11 -0700 Yinghai Lu ying...@kernel.org wrote: On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng linf...@cn.fujitsu.com wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is

Re: [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case

2013-04-08 Thread Lin Feng
Hi Yinghai, On 04/09/2013 02:40 AM, Yinghai Lu wrote: On Mon, Apr 8, 2013 at 2:56 AM, Lin Feng linf...@cn.fujitsu.com wrote: In hot add node(memory) case, vmemmap pages are always allocated from other node, that is broken, and should be fixed. vmemmap should be on local node even for hot