Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+

2019-06-25 Thread Patrick Williams
On Tue, Jun 25, 2019 at 03:38:59PM +0200, Gregory CLEMENT wrote: > First you can add my > Acked-by: Gregory CLEMENT Thanks for the review Gregory. > Then as the second patch is a fix, you should add the fix tag: "Fixes: > 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the

Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+

2019-06-25 Thread Gregory CLEMENT
Hi, > On Tue, Jun 18, 2019 at 6:01 PM wrote: > >> From: Patrick Williams >> >> The 37xx GPIO config registers are only 32 bits long and >> span 2 registers for the NB GPIO controller. The function >> to calculate the offset was missing the increase to the >> config register. >> >> I have

Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+

2019-06-25 Thread Linus Walleij
On Tue, Jun 18, 2019 at 6:01 PM wrote: > From: Patrick Williams > > The 37xx GPIO config registers are only 32 bits long and > span 2 registers for the NB GPIO controller. The function > to calculate the offset was missing the increase to the > config register. > > I have tested both raw gpio

[PATCH 0/2] pinctl: armada-37xx: fix for pins 32+

2019-06-18 Thread alpawi
From: Patrick Williams The 37xx GPIO config registers are only 32 bits long and span 2 registers for the NB GPIO controller. The function to calculate the offset was missing the increase to the config register. I have tested both raw gpio access and interrupts using libgpiod utilities on an