Re: [PATCH 0/2] scsi: add support for request batching

2019-07-11 Thread Martin K. Petersen
Paolo, > Stefan answered, and the series now has three reviews! It may be late > for 5.3 but I hope this can go in soon. I queued these up for 5.4. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: add support for request batching

2019-07-05 Thread Paolo Bonzini
On 05/07/19 09:13, Hannes Reinecke wrote: > On 6/27/19 10:17 AM, Paolo Bonzini wrote: >> On 27/06/19 05:37, Martin K. Petersen wrote: Ping? Are there any more objections? >>> It's a core change so we'll need some more reviews. I suggest you >>> resubmit. >> Resubmit exactly the same patches?

Re: [PATCH 0/2] scsi: add support for request batching

2019-07-05 Thread Hannes Reinecke
On 6/27/19 10:17 AM, Paolo Bonzini wrote: > On 27/06/19 05:37, Martin K. Petersen wrote: >>> Ping? Are there any more objections? >> It's a core change so we'll need some more reviews. I suggest you >> resubmit. > > Resubmit exactly the same patches? > Where is the ->commit_rqs() callback invoked

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-27 Thread Paolo Bonzini
On 27/06/19 05:37, Martin K. Petersen wrote: >> Ping? Are there any more objections? > It's a core change so we'll need some more reviews. I suggest you > resubmit. Resubmit exactly the same patches? Paolo

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-26 Thread Martin K. Petersen
Paolo, > Ping? Are there any more objections? It's a core change so we'll need some more reviews. I suggest you resubmit. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-26 Thread Paolo Bonzini
On 26/06/19 16:14, Douglas Gilbert wrote: > > I have no objections, just a few questions. > > To implement this is the scsi_debug driver, a per device queue would > need to be added, correct? Yes, queuecommand would then return before calling schedule_resp (for all requests except the one with S

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-26 Thread Douglas Gilbert
On 2019-06-26 9:51 a.m., Paolo Bonzini wrote: On 30/05/19 13:28, Paolo Bonzini wrote: This allows a list of requests to be issued, with the LLD only writing the hardware doorbell when necessary, after the last request was prepared. This is more efficient if we have lists of requests to issue, pa

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-26 Thread Paolo Bonzini
On 30/05/19 13:28, Paolo Bonzini wrote: > This allows a list of requests to be issued, with the LLD only writing > the hardware doorbell when necessary, after the last request was prepared. > This is more efficient if we have lists of requests to issue, particularly > on virtualized hardware, where

Re: [PATCH 0/2] scsi: add support for request batching

2019-06-10 Thread Stefan Hajnoczi
On Thu, May 30, 2019 at 01:28:09PM +0200, Paolo Bonzini wrote: > This allows a list of requests to be issued, with the LLD only writing > the hardware doorbell when necessary, after the last request was prepared. > This is more efficient if we have lists of requests to issue, particularly > on virt

[PATCH 0/2] scsi: add support for request batching

2019-05-30 Thread Paolo Bonzini
This allows a list of requests to be issued, with the LLD only writing the hardware doorbell when necessary, after the last request was prepared. This is more efficient if we have lists of requests to issue, particularly on virtualized hardware, where writing the doorbell is more expensive than on