Re: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD

2018-12-11 Thread Christoph Hellwig
On Tue, Dec 11, 2018 at 06:22:27PM +, Parshuram Raju Thombare wrote: > One reason of using device mapper here is to use existing tools like > 'dmsetup', otherwise some user space application is needed and may be > some changes in block layer to pass the crypto information (crypto > algorithm, k

RE: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD

2018-12-11 Thread Parshuram Raju Thombare
t...@kernel.org; jba...@fb.com; michaelcalla...@fb.com; >snit...@redhat.com; osan...@fb.com; keith.bu...@intel.com; >ming@redhat.com; s...@fb.com; dennissz...@gmail.com; Alan Douglas >; Janek Kotas ; Rafal Ciepiela > >Subject: Re: [PATCH 0/2] scsi: ufs: add real time/inline

Re: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD

2018-12-11 Thread Christoph Hellwig
Patch 1 is missing in your series. But even without looking at it I think your design doesn't make a whole lot of sense. If the encryption is implemented in the ufs driver you should not need device mapper support for it, just ufs driver support and maybe a little block layer glue.

[PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD

2018-12-11 Thread Parshuram Thombare
Hello, This patch series add inline / real time encryption support to UFS host controller driver. It include following patches 0001-block-add-bi_crypto_ctx-variable-in-struct-bio.patch Add 'void *bi_crypto_ctx' variable in 'struct bio' to embded crypto configuration information, which is used by l