Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-03-06 Thread Sage Weil
Hi Milosz, Thanks, I've added this to the testing branch! sage On Mon, 3 Mar 2014, Milosz Tanski wrote: > Hey guys, I'm terribly sorry but apparently this got stuck in my draft > mailbox for 3 months. Since we've been running this on both our test / > prod clusters I would say this is

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-03-06 Thread Sage Weil
Hi Milosz, Thanks, I've added this to the testing branch! sage On Mon, 3 Mar 2014, Milosz Tanski wrote: Hey guys, I'm terribly sorry but apparently this got stuck in my draft mailbox for 3 months. Since we've been running this on both our test / prod clusters I would say this is

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-03-03 Thread Milosz Tanski
Hey guys, I'm terribly sorry but apparently this got stuck in my draft mailbox for 3 months. Since we've been running this on both our test / prod clusters I would say this is sufficiently tested. I've looked at the code and tested this for a week now on test cluster and it looks good. It does

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-03-03 Thread Milosz Tanski
Hey guys, I'm terribly sorry but apparently this got stuck in my draft mailbox for 3 months. Since we've been running this on both our test / prod clusters I would say this is sufficiently tested. I've looked at the code and tested this for a week now on test cluster and it looks good. It does

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-01-03 Thread Milosz Tanski
I'm going to look the patches and the issue in full detail. In the meantime do you guys have the oops back trace. I have some other fscache patches that haven't made it upstream yet that might have been masking this issue for me. On Fri, Dec 27, 2013 at 10:51 PM, Li Wang wrote: > Hi Milosz, >

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-01-03 Thread Milosz Tanski
I'm going to look the patches and the issue in full detail. In the meantime do you guys have the oops back trace. I have some other fscache patches that haven't made it upstream yet that might have been masking this issue for me. On Fri, Dec 27, 2013 at 10:51 PM, Li Wang liw...@ubuntukylin.com

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-27 Thread Li Wang
Hi Milosz, As far as I know, logically, currently fscache does not play as write cache for Ceph, except that there is a call to ceph_readpage_to_fscache() in ceph_writepage(), but that is nothing related to our test case. According to our observation, our test case never goes through

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-27 Thread Li Wang
Hi Milosz, As far as I know, logically, currently fscache does not play as write cache for Ceph, except that there is a call to ceph_readpage_to_fscache() in ceph_writepage(), but that is nothing related to our test case. According to our observation, our test case never goes through

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Yunchuan Wen
Hi, Milosz I am not very sure about how to enable caching in write path. I just compile the latest kernel with "Enable Ceph client caching support", start cachefilesd, and mount cephfs with -o fsc. Then, the kernel will panic easily when the script runs to "dd if=cephfs/foo of=/dev/null bs=8

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Milosz Tanski
Li, I looked at the patchset am I correct that this only happens when we enable caching in the write path? - Milosz On Thu, Dec 26, 2013 at 9:29 AM, Li Wang wrote: > From: Yunchuan Wen > > The following scripts could easily panic the kernel, > > #!/bin/bash > mount -t ceph -o fsc MONADDR:/

[PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Li Wang
From: Yunchuan Wen The following scripts could easily panic the kernel, #!/bin/bash mount -t ceph -o fsc MONADDR:/ cephfs rm -rf cephfs/foo dd if=/dev/zero of=cephfs/foo bs=8 count=512 echo 3 > /proc/sys/vm/drop_caches dd if=cephfs/foo of=/dev/null bs=8 count=1024 This is due to when writing a

[PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Li Wang
From: Yunchuan Wen yunchuan...@ubuntukylin.com The following scripts could easily panic the kernel, #!/bin/bash mount -t ceph -o fsc MONADDR:/ cephfs rm -rf cephfs/foo dd if=/dev/zero of=cephfs/foo bs=8 count=512 echo 3 /proc/sys/vm/drop_caches dd if=cephfs/foo of=/dev/null bs=8 count=1024

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Milosz Tanski
Li, I looked at the patchset am I correct that this only happens when we enable caching in the write path? - Milosz On Thu, Dec 26, 2013 at 9:29 AM, Li Wang liw...@ubuntukylin.com wrote: From: Yunchuan Wen yunchuan...@ubuntukylin.com The following scripts could easily panic the kernel,

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2013-12-26 Thread Yunchuan Wen
Hi, Milosz I am not very sure about how to enable caching in write path. I just compile the latest kernel with Enable Ceph client caching support, start cachefilesd, and mount cephfs with -o fsc. Then, the kernel will panic easily when the script runs to dd if=cephfs/foo of=/dev/null bs=8