Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-13 Thread Shuah Khan
On 8/13/19 6:36 AM, Laurent Pinchart wrote: Hi Helen, On Tue, Aug 13, 2019 at 09:25:01AM -0300, Helen Koike wrote: On 8/13/19 6:56 AM, Laurent Pinchart wrote: On Mon, Aug 12, 2019 at 08:41:33PM -0300, Helen Koike wrote: On 8/12/19 7:14 PM, Shuah Khan wrote: On 8/12/19 1:10 PM, Shuah Khan

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-13 Thread Laurent Pinchart
Hi Helen, On Tue, Aug 13, 2019 at 09:25:01AM -0300, Helen Koike wrote: > On 8/13/19 6:56 AM, Laurent Pinchart wrote: > > On Mon, Aug 12, 2019 at 08:41:33PM -0300, Helen Koike wrote: > >> On 8/12/19 7:14 PM, Shuah Khan wrote: > >>> On 8/12/19 1:10 PM, Shuah Khan wrote: > On 8/12/19 12:52 PM,

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-13 Thread Helen Koike
On 8/13/19 6:56 AM, Laurent Pinchart wrote: > Hi Helen, > > On Mon, Aug 12, 2019 at 08:41:33PM -0300, Helen Koike wrote: >> On 8/12/19 7:14 PM, Shuah Khan wrote: >>> On 8/12/19 1:10 PM, Shuah Khan wrote: On 8/12/19 12:52 PM, André Almeida wrote: > On 8/12/19 11:08 AM, Shuah Khan

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-13 Thread Laurent Pinchart
Hi Helen, On Mon, Aug 12, 2019 at 08:41:33PM -0300, Helen Koike wrote: > On 8/12/19 7:14 PM, Shuah Khan wrote: > > On 8/12/19 1:10 PM, Shuah Khan wrote: > >> On 8/12/19 12:52 PM, André Almeida wrote: > >>> On 8/12/19 11:08 AM, Shuah Khan wrote: > On 8/9/19 9:51 PM, Helen Koike wrote: > >

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread Shuah Khan
On 8/12/19 5:41 PM, Helen Koike wrote: Hi Shuah, On 8/12/19 7:14 PM, Shuah Khan wrote: On 8/12/19 1:10 PM, Shuah Khan wrote: On 8/12/19 12:52 PM, André Almeida wrote: Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: On 8/9/19 9:51 PM, Helen Koike wrote: Hi Andre, Thanks for testing this.

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread Helen Koike
Hi Shuah, On 8/12/19 7:14 PM, Shuah Khan wrote: > On 8/12/19 1:10 PM, Shuah Khan wrote: >> On 8/12/19 12:52 PM, André Almeida wrote: >>> Hi Shuah, >>> >>> On 8/12/19 11:08 AM, Shuah Khan wrote: On 8/9/19 9:51 PM, Helen Koike wrote: > Hi Andre, > > Thanks for testing this. >

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread Shuah Khan
On 8/12/19 1:10 PM, Shuah Khan wrote: On 8/12/19 12:52 PM, André Almeida wrote: Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: On 8/9/19 9:51 PM, Helen Koike wrote: Hi Andre, Thanks for testing this. On 8/9/19 9:24 PM, André Almeida wrote: On 8/9/19 9:17 PM, Shuah Khan wrote: Hi Andre,

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread Shuah Khan
On 8/12/19 12:52 PM, André Almeida wrote: Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: On 8/9/19 9:51 PM, Helen Koike wrote: Hi Andre, Thanks for testing this. On 8/9/19 9:24 PM, André Almeida wrote: On 8/9/19 9:17 PM, Shuah Khan wrote: Hi Andre, On 8/9/19 5:52 PM, André Almeida

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread André Almeida
Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: > On 8/9/19 9:51 PM, Helen Koike wrote: >> Hi Andre, >> >> Thanks for testing this. >> >> On 8/9/19 9:24 PM, André Almeida wrote: >>> On 8/9/19 9:17 PM, Shuah Khan wrote: Hi Andre, On 8/9/19 5:52 PM, André Almeida wrote: > Hello

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread Shuah Khan
On 8/9/19 9:51 PM, Helen Koike wrote: Hi Andre, Thanks for testing this. On 8/9/19 9:24 PM, André Almeida wrote: On 8/9/19 9:17 PM, Shuah Khan wrote: Hi Andre, On 8/9/19 5:52 PM, André Almeida wrote: Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread Helen Koike
Hi Andre, Thanks for testing this. On 8/9/19 9:24 PM, André Almeida wrote: > On 8/9/19 9:17 PM, Shuah Khan wrote: >> Hi Andre, >> >> On 8/9/19 5:52 PM, André Almeida wrote: >>> Hello Shuah, >>> >>> Thanks for the patch, I did some comments below. >>> >>> On 8/9/19 6:45 PM, Shuah Khan wrote:

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread Shuah Khan
On 8/9/19 6:24 PM, André Almeida wrote: On 8/9/19 9:17 PM, Shuah Khan wrote: Hi Andre, On 8/9/19 5:52 PM, André Almeida wrote: Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah Khan wrote: vimc uses Component API to split the driver into functional

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
On 8/9/19 9:17 PM, Shuah Khan wrote: > Hi Andre, > > On 8/9/19 5:52 PM, André Almeida wrote: >> Hello Shuah, >> >> Thanks for the patch, I did some comments below. >> >> On 8/9/19 6:45 PM, Shuah Khan wrote: >>> vimc uses Component API to split the driver into functional components. >>> The real

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread Shuah Khan
Hi Andre, On 8/9/19 5:52 PM, André Almeida wrote: Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah Khan wrote: vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity

[PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread Shuah Khan
vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component structure added a level of complexity making it hard to maintain without adding any real benefit. The sensor is one vimc component that would