Changes since RFC: - "KVM: x86: disconnect kvm_check_cpuid() from vcpu->arch.cpuid_entries" added to allow running kvm_check_cpuid() before vcpu->arch.cpuid_entries/ vcpu->arch.cpuid_nent are changed [Sean Christopherson] - Shorten local variable names in kvm_vcpu_ioctl_set_cpuid[,2] [Sean Christopherson] - Drop unneeded 'out' labels from kvm_vcpu_ioctl_set_cpuid[,2] and return directly whenever possible [Sean Christopherson]
Original description: With QEMU and newer AMD CPUs (namely: Epyc 'Rome') the current limit for KVM_MAX_CPUID_ENTRIES(80) is reported to be hit. Last time it was raised from '40' in 2010. We can, of course, just bump it a little bit to fix the immediate issue but the report made me wonder why we need to pre- allocate vcpu->arch.cpuid_entries array instead of sizing it dynamically. This RFC is intended to feed my curiosity. Very mildly tested with selftests/kvm-unit-tests and nothing seems to break. I also don't have access to the system where the original issue was reported but chances we're fixing it are very good IMO as just the second patch alone was reported to be sufficient. Reported-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Vitaly Kuznetsov (3): KVM: x86: disconnect kvm_check_cpuid() from vcpu->arch.cpuid_entries KVM: x86: allocate vcpu->arch.cpuid_entries dynamically KVM: x86: bump KVM_MAX_CPUID_ENTRIES arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/kvm/cpuid.c | 123 +++++++++++++++++++------------- arch/x86/kvm/x86.c | 1 + 3 files changed, 75 insertions(+), 53 deletions(-) -- 2.25.4
