Re: [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom

2016-09-27 Thread Mark Rutland
On Mon, Sep 26, 2016 at 03:01:36PM -0500, Josh Poimboeuf wrote: > On Mon, Sep 26, 2016 at 04:16:16PM +0100, Mark Rutland wrote: > > Today, show_stack() accepts a NULL task parameter, which it takes to mean > > the > > current task. However, as noted in tip/x86/asm commit: > > > > 81539169f28332

Re: [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom

2016-09-26 Thread Mark Rutland
On Mon, Sep 26, 2016 at 03:01:36PM -0500, Josh Poimboeuf wrote: > On Mon, Sep 26, 2016 at 04:16:16PM +0100, Mark Rutland wrote: > > Today, show_stack() accepts a NULL task parameter, which it takes to mean > > the > > current task. However, as noted in tip/x86/asm commit: > > > > 81539169f28332

Re: [PATCH 0/3] Kill off show_stack() NULL-implies-current idiom

2016-09-26 Thread Josh Poimboeuf
On Mon, Sep 26, 2016 at 04:16:16PM +0100, Mark Rutland wrote: > Today, show_stack() accepts a NULL task parameter, which it takes to mean the > current task. However, as noted in tip/x86/asm commit: > > 81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention") > > ... having a NUL

[PATCH 0/3] Kill off show_stack() NULL-implies-current idiom

2016-09-26 Thread Mark Rutland
Today, show_stack() accepts a NULL task parameter, which it takes to mean the current task. However, as noted in tip/x86/asm commit: 81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention") ... having a NULL task parameter imply current leads to subtle bugs in stack walking code