Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-21 Thread Tejun Heo
On Mon, Feb 20, 2017 at 07:15:34PM +0100, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] pata_falcon: build fix for block layer changes > > commit aebf526b53ae ("block: fold cmd_type into the REQ_OP_ > space") from the block tree removes cmd_type so pata_fal

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-20 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, February 15, 2017 09:45:53 AM Geert Uytterhoeven wrote: > On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz > wrote: > > This patchset adds m68k/Atari Falcon PATA support to libata. > > The major difference in the new libata's pata_falcon host > > driver when compared

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-15 Thread Geert Uytterhoeven
On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz wrote: > This patchset adds m68k/Atari Falcon PATA support to libata. > The major difference in the new libata's pata_falcon host > driver when compared to legacy IDE's falconide host driver is > that we are using polled PIO mode and thus

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-01 Thread Michael Schmitz
Hi Finn, Am 01.02.2017 um 21:40 schrieb Finn Thain: > > On Fri, 27 Jan 2017, Michael Schmitz wrote: > >> Am 26.01.2017 um 21:47 schrieb Finn Thain: >> >>> This would imply CPU overhead that is half of that which mac_scsi >>> incurs. That's the best case, but I see no reason to expect worse >>

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-01 Thread Geert Uytterhoeven
Hi Finn, On Wed, Feb 1, 2017 at 9:40 AM, Finn Thain wrote: > okay. (BTW, where is the IDE status register found anyway?) In the IDE device. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversa

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-02-01 Thread Finn Thain
On Fri, 27 Jan 2017, Michael Schmitz wrote: > Am 26.01.2017 um 21:47 schrieb Finn Thain: > > > This would imply CPU overhead that is half of that which mac_scsi > > incurs. That's the best case, but I see no reason to expect worse > > performance than PDMA gets. > > But how much more overhead

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-26 Thread Michael Schmitz
Hi Finn, Am 26.01.2017 um 21:47 schrieb Finn Thain: >> I hadn't considered that. Can PDMA for Falcon SCSI coexist with >> interrupt-using DMA for TT SCSI in the same driver (i.e. as runtime >> options)? > > Sure, why not? > >> How much overhead and latency would polling for DMA completion ad

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-26 Thread Finn Thain
On Thu, 26 Jan 2017, Geert Uytterhoeven wrote: > Hi Finn, > > On Thu, Jan 26, 2017 at 9:47 AM, Finn Thain > wrote: > > The difficulty will be arranging for disabled FDC & IDE interrupt > > sources during SCSI DMA, and disabled SCSI & IDE interrupt sources > > during FDC DMA. (Not all 5380 in

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-26 Thread Geert Uytterhoeven
Hi Finn, On Thu, Jan 26, 2017 at 9:47 AM, Finn Thain wrote: > The difficulty will be arranging for disabled FDC & IDE interrupt sources > during SCSI DMA, and disabled SCSI & IDE interrupt sources during FDC DMA. > (Not all 5380 interrupts can be disabled; no idea about the IDE device or > WD1772

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-26 Thread Finn Thain
On Mon, 23 Jan 2017, Michael Schmitz wrote: > > Am 21.01.2017 um 20:37 schrieb Finn Thain: > > > > > Actually, the fundamental problem you are describing is partly solved. > > By polling for DMA completion with local irqs disabled, we mostly > > avoid the need for the stdma.c "lock" because

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-23 Thread Michael Schmitz
Hi Finn, Am 21.01.2017 um 20:37 schrieb Finn Thain: >> The MFP interrupt in question is the same as the one used by IDE >> (wired-OR of IDE, FDC and SCSI), so we would still have to figure out >> where the interrupt originated. > > I thought you said the driver you're testing does not use any

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-20 Thread Finn Thain
On Fri, 20 Jan 2017, Michael Schmitz wrote: > Am 15.01.2017 um 17:42 schrieb Finn Thain: > > >> No, we can't check either FDC or SCSI interrupts (or indeed any chip > >> registers) without touching the ST-DMA. The moment we select a FDC or > >> SCSI register for read, DMA is terminated no ques

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-19 Thread Michael Schmitz
Hi Finn, Am 15.01.2017 um 17:42 schrieb Finn Thain: >> No, we can't check either FDC or SCSI interrupts (or indeed any chip >> registers) without touching the ST-DMA. The moment we select a FDC or >> SCSI register for read, DMA is terminated no questions asked. >> > > Perhaps we can convert DM

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Finn Thain
On Sun, 15 Jan 2017, Michael Schmitz wrote: > Am 15.01.2017 um 12:47 schrieb Finn Thain: > > > For the sake of discussion, I'll assume that the FDC driver will not > > be using DMA. (Perhaps FDC and SCSI can share the ST-DMA chip, using > > the present locking mechanism, but it would not simpl

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Michael Schmitz
Hi Finn, Am 15.01.2017 um 12:47 schrieb Finn Thain: > For the sake of discussion, I'll assume that the FDC driver will not > be using DMA. (Perhaps FDC and SCSI can share the ST-DMA chip, using > the present locking mechanism, but it would not simplify things much: > when IDE no longer participat

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Finn Thain
On Sat, 14 Jan 2017, Michael Schmitz wrote: > Am 13.01.2017 um 15:33 schrieb Finn Thain: > > >> The case I'm worried about is both IDE and SCSI raising an interrupt. > >> We don't currently mask the IDE/ST-DMA interrupt so a stacked > >> interrupt must be processed in the same pass as the init

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-14 Thread Michael Schmitz
Hi Finn, Am 13.01.2017 um 15:33 schrieb Finn Thain: >> The case I'm worried about is both IDE and SCSI raising an interrupt. We >> don't currently mask the IDE/ST-DMA interrupt so a stacked interrupt >> must be processed in the same pass as the initial interrupt or it will >> get dropped. We'd

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-12 Thread Finn Thain
On Wed, 11 Jan 2017, Michael Schmitz wrote: > What is still correct is that the IDE driver does use the interrupt > only, not the ST-DMA chip. And a single IDE interrupt can be correctly > assigned to IDE by looking at the status register. > > With the SCSI (and IIRC also floppy) interrupts, w

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-10 Thread Michael Schmitz
Bartlomiej, >> How is polling implemented in libata? Sleeping for something >> approximating the average seek latency shouldn't hurt but spinning >> wont be acceptable for a low performance single CPU architecture like >> the Falcon. > > You can find actual implementation in libata-sff.c. > > Ple

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-10 Thread Tejun Heo
On Fri, Dec 30, 2016 at 03:01:15PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset adds m68k/Atari Falcon PATA support to libata. > The major difference in the new libata's pata_falcon host > driver when compared to legacy IDE's falconide host driver is > that we are using polled P

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-10 Thread Tejun Heo
Hello, On Mon, Jan 09, 2017 at 05:11:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Disabling CONFIG_ATA_VERBOSE_ERROR saved 1380 bytes, which is less than the > > value advertised by Kconfig (6KB). > > If it is only ~1kB nowadays I would vote for making the error logging always > verbose and j

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, January 06, 2017 10:01:49 AM Michael Schmitz wrote: > Hi Bartlomiej, > > thanks for caring to support our legacy PATA systems! > > On Sat, Dec 31, 2016 at 3:01 AM, Bartlomiej Zolnierkiewicz > wrote: > > Hi, > > > > This patchset adds m68k/Atari Falcon PATA support to libata. > >

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-09 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, January 03, 2017 11:49:16 AM Geert Uytterhoeven wrote: > Hi Bartlomiej, > > On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz > wrote: > > This patchset adds m68k/Atari Falcon PATA support to libata. > > Thanks for your series! > > That leaves us with 4 to go ;-) > >

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-05 Thread Michael Schmitz
Hi Bartlomiej, thanks for caring to support our legacy PATA systems! On Sat, Dec 31, 2016 at 3:01 AM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset adds m68k/Atari Falcon PATA support to libata. > The major difference in the new libata's pata_falcon host > driver when compared to lega

Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2017-01-03 Thread Geert Uytterhoeven
Hi Bartlomiej, On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz wrote: > This patchset adds m68k/Atari Falcon PATA support to libata. Thanks for your series! That leaves us with 4 to go ;-) CONFIG_BLK_DEV_GAYLE CONFIG_BLK_DEV_BUDDHA CONFIG_BLK_DEV_MAC_IDE CONFIG_BLK_D

[PATCH 0/3] ata: add m68k/Atari Falcon PATA support

2016-12-30 Thread Bartlomiej Zolnierkiewicz
Hi, This patchset adds m68k/Atari Falcon PATA support to libata. The major difference in the new libata's pata_falcon host driver when compared to legacy IDE's falconide host driver is that we are using polled PIO mode and thus avoiding the need for STDMA locking magic altogether. Tested under AR