Re: [PATCH 0/3] exec: Transform exec_update_mutex into a rw_semaphore

2020-12-03 Thread Davidlohr Bueso
On Thu, 03 Dec 2020, Linus Torvalds wrote: On Thu, Dec 3, 2020 at 12:10 PM Eric W. Biederman wrote: The simplest and most robust solution appears to be making exec_update_mutex a read/write lock and having everything execept for exec take the lock for read. Looks sane to me. I'd like the

Re: [PATCH 0/3] exec: Transform exec_update_mutex into a rw_semaphore

2020-12-03 Thread Waiman Long
On 12/3/20 5:42 PM, Linus Torvalds wrote: On Thu, Dec 3, 2020 at 12:10 PM Eric W. Biederman wrote: The simplest and most robust solution appears to be making exec_update_mutex a read/write lock and having everything execept for exec take the lock for read. Looks sane to me. I'd like the

Re: [PATCH 0/3] exec: Transform exec_update_mutex into a rw_semaphore

2020-12-03 Thread Linus Torvalds
On Thu, Dec 3, 2020 at 12:10 PM Eric W. Biederman wrote: > > The simplest and most robust solution appears to be making > exec_update_mutex a read/write lock and having everything execept for > exec take the lock for read. Looks sane to me. I'd like the locking people to look at the

[PATCH 0/3] exec: Transform exec_update_mutex into a rw_semaphore

2020-12-03 Thread Eric W. Biederman
Recently syzbot reported[0] that there is a deadlock amongst the users of exec_update_mutex. The simplest and most robust solution appears to be making exec_update_mutex a read/write lock and having everything execept for exec take the lock for read. This set of changes upgrades rwsem so it