Re: [PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Sun, 7 Mar 2021 22:25:27 -0500 you wrote: > there are two drivers(zatm and idt77252) using PRIV() (i.e. atm->phy_data) > to store private data, but the driver happens to populate wrong > pointers: atm->dev_data. which actua

Re: [PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-08 Thread Tong Zhang
I have this emulated device in QEMU, -- and I agree with you that probably no one has been using it for a while IMHO, given the quality of the driver it also make sense to drop the support completely or we at least need to fix some obvious issues here. Best, - Tong On Mon, Mar 8, 2021 at 1:06 PM A

Re: [PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-08 Thread Alexander Duyck
Hi Tong, Is this direct-assigned hardware or is QEMU being used to emulate the hardware here? Admittedly I don't know that much about ATM, so I am not sure when/if those phys would have gone out of production. However since the code dates back to 2005 I am guessing it is on the old side. Ultimate

Re: [PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-08 Thread Tong Zhang
Hi Alex, attached is the kernel log for zatm(uPD98402) -- I also have idt77252's log -- which is similar to this one -- I think it makes sense to drop if no one is actually using it -- - Tong [5.740774] BUG: KASAN: null-ptr-deref in uPD98402_start+0x5e/0x219 [uPD98402] [5.741179] Write of

Re: [PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-08 Thread Alexander Duyck
On Mon, Mar 8, 2021 at 12:39 AM Tong Zhang wrote: > > there are two drivers(zatm and idt77252) using PRIV() (i.e. atm->phy_data) > to store private data, but the driver happens to populate wrong > pointers: atm->dev_data. which actually cause null-ptr-dereference in > following PRIV(dev). This pat

[PATCH 0/3] fix a couple of atm->phy_data related issues

2021-03-07 Thread Tong Zhang
there are two drivers(zatm and idt77252) using PRIV() (i.e. atm->phy_data) to store private data, but the driver happens to populate wrong pointers: atm->dev_data. which actually cause null-ptr-dereference in following PRIV(dev). This patch series attemps to fix those two issues along with a typo