Re: [PATCH 0/3] scheduler include file reorganization

2013-02-15 Thread Li Zefan
On 2013/2/13 17:15, Ingo Molnar wrote: > > * Namhyung Kim wrote: > >> Hi, >> >> On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: >>> * Clark Williams wrote: >>> I figured that was coming. :) >>> >>> ;-) >>> I'll look at it again and see about pulling the autogroup/cgroup

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-15 Thread Li Zefan
On 2013/2/13 17:15, Ingo Molnar wrote: * Namhyung Kim namhy...@kernel.org wrote: Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: * Clark Williams willi...@redhat.com wrote: I figured that was coming. :) ;-) I'll look at it again and see about pulling the

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Namhyung Kim
On Wed, 13 Feb 2013 09:19:37 -0600, Clark Williams wrote: > On Wed, 13 Feb 2013 10:15:12 +0100 > Ingo Molnar wrote: >> * Namhyung Kim wrote: >> > On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: >> > > * Clark Williams wrote: >> > > >> > >> I figured that was coming. :) >> > > >> > > ;-)

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Clark Williams
On Wed, 13 Feb 2013 10:15:12 +0100 Ingo Molnar wrote: > > * Namhyung Kim wrote: > > > Hi, > > > > On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: > > > * Clark Williams wrote: > > > > > >> I figured that was coming. :) > > > > > > ;-) > > > > > >> I'll look at it again and see about

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Ingo Molnar
* Namhyung Kim wrote: > Hi, > > On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: > > * Clark Williams wrote: > > > >> I figured that was coming. :) > > > > ;-) > > > >> I'll look at it again and see about pulling the > >> autogroup/cgroup stuff into it's own header. After that it's >

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Ingo Molnar
* Namhyung Kim namhy...@kernel.org wrote: Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: * Clark Williams willi...@redhat.com wrote: I figured that was coming. :) ;-) I'll look at it again and see about pulling the autogroup/cgroup stuff into it's own header.

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Clark Williams
On Wed, 13 Feb 2013 10:15:12 +0100 Ingo Molnar mi...@kernel.org wrote: * Namhyung Kim namhy...@kernel.org wrote: Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: * Clark Williams willi...@redhat.com wrote: I figured that was coming. :) ;-) I'll look at

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-13 Thread Namhyung Kim
On Wed, 13 Feb 2013 09:19:37 -0600, Clark Williams wrote: On Wed, 13 Feb 2013 10:15:12 +0100 Ingo Molnar mi...@kernel.org wrote: * Namhyung Kim namhy...@kernel.org wrote: On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: * Clark Williams willi...@redhat.com wrote: I figured that

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-12 Thread Namhyung Kim
Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: > * Clark Williams wrote: > >> I figured that was coming. :) > > ;-) > >> I'll look at it again and see about pulling the >> autogroup/cgroup stuff into it's own header. After that it's >> probably going to require some serious

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-12 Thread Namhyung Kim
Hi, On Mon, 11 Feb 2013 10:54:58 +0100, Ingo Molnar wrote: * Clark Williams willi...@redhat.com wrote: I figured that was coming. :) ;-) I'll look at it again and see about pulling the autogroup/cgroup stuff into it's own header. After that it's probably going to require some serious

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-11 Thread Ingo Molnar
* Clark Williams wrote: > I figured that was coming. :) ;-) > I'll look at it again and see about pulling the > autogroup/cgroup stuff into it's own header. After that it's > probably going to require some serious changes. > > Any suggestions? I'd suggest doing it as finegrained as

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-11 Thread Ingo Molnar
* Clark Williams willi...@redhat.com wrote: I figured that was coming. :) ;-) I'll look at it again and see about pulling the autogroup/cgroup stuff into it's own header. After that it's probably going to require some serious changes. Any suggestions? I'd suggest doing it as

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-08 Thread Clark Williams
On Fri, 8 Feb 2013 15:18:41 +0100 Ingo Molnar wrote: > > * Clark Williams wrote: > > > On Thu, 7 Feb 2013 20:52:57 +0100 > > Ingo Molnar wrote: > > > > > > > > * Ingo Molnar wrote: > > > > > > > > > > > * Ingo Molnar wrote: > > > > > > > > > Yeah, that looks pretty good. > > > > > >

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-08 Thread Ingo Molnar
* Clark Williams wrote: > On Thu, 7 Feb 2013 20:52:57 +0100 > Ingo Molnar wrote: > > > > > * Ingo Molnar wrote: > > > > > > > > * Ingo Molnar wrote: > > > > > > > Yeah, that looks pretty good. > > > > > > > > I'll give it some testing. > > > > > > Found one build error so far, applied

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-08 Thread Ingo Molnar
* Clark Williams willi...@redhat.com wrote: On Thu, 7 Feb 2013 20:52:57 +0100 Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: Yeah, that looks pretty good. I'll give it some testing. Found

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-08 Thread Clark Williams
On Fri, 8 Feb 2013 15:18:41 +0100 Ingo Molnar mi...@kernel.org wrote: * Clark Williams willi...@redhat.com wrote: On Thu, 7 Feb 2013 20:52:57 +0100 Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote:

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Clark Williams
On Thu, 7 Feb 2013 20:52:57 +0100 Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > * Ingo Molnar wrote: > > > > > Yeah, that looks pretty good. > > > > > > I'll give it some testing. > > > > Found one build error so far, applied the fix below. > > Another one was in NOMMU mode

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > Yeah, that looks pretty good. > > > > I'll give it some testing. > > Found one build error so far, applied the fix below. Another one was in NOMMU mode (fixed below) - a hidden sched.h include file dependency in mm/nommu.c. It's

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Ingo Molnar wrote: > Yeah, that looks pretty good. > > I'll give it some testing. Found one build error so far, applied the fix below. Thanks, Ingo --- kernel/mutex.c |1 + 1 file changed, 1 insertion(+) Index: linux/kernel/mutex.c

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Clark Williams wrote: > > Ingo, > > Is this more in line with what you wanted? > > I moved the sysctl bits out into include/linux/sched/sysctl.h, then > updated any source dependent on sysctl bits, then added my SCHED_RR > tuning knob, then finally created include/linux/sched/rt.h to hold

[PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Clark Williams
Ingo, Is this more in line with what you wanted? I moved the sysctl bits out into include/linux/sched/sysctl.h, then updated any source dependent on sysctl bits, then added my SCHED_RR tuning knob, then finally created include/linux/sched/rt.h to hold most of the rt scheduler specific bits.

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Clark Williams willi...@redhat.com wrote: Ingo, Is this more in line with what you wanted? I moved the sysctl bits out into include/linux/sched/sysctl.h, then updated any source dependent on sysctl bits, then added my SCHED_RR tuning knob, then finally created

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: Yeah, that looks pretty good. I'll give it some testing. Found one build error so far, applied the fix below. Thanks, Ingo --- kernel/mutex.c |1 + 1 file changed, 1 insertion(+) Index: linux/kernel/mutex.c

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: Yeah, that looks pretty good. I'll give it some testing. Found one build error so far, applied the fix below. Another one was in NOMMU mode (fixed below) - a hidden sched.h include file dependency in

Re: [PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Clark Williams
On Thu, 7 Feb 2013 20:52:57 +0100 Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: Yeah, that looks pretty good. I'll give it some testing. Found one build error so far, applied the fix below. Another

[PATCH 0/3] scheduler include file reorganization

2013-02-07 Thread Clark Williams
Ingo, Is this more in line with what you wanted? I moved the sysctl bits out into include/linux/sched/sysctl.h, then updated any source dependent on sysctl bits, then added my SCHED_RR tuning knob, then finally created include/linux/sched/rt.h to hold most of the rt scheduler specific bits.