Re: [PATCH 0/3] task: Making tasks on the runqueue rcu protected

2019-09-03 Thread Peter Zijlstra
On Tue, Sep 03, 2019 at 08:44:40AM -0700, Linus Torvalds wrote: > That said, it won't affect any of the core architectures much, because > smp_store_release() isn't that expensive (it's just a compiler barrier > on x86, it's a cheap instruction on arm64, and it should be very cheap > on any other

Re: [PATCH 0/3] task: Making tasks on the runqueue rcu protected

2019-09-03 Thread Linus Torvalds
On Mon, Sep 2, 2019 at 9:50 PM Eric W. Biederman wrote: > > I have split this work into 3 simple patches, so the code is straight > forward to review and so that if any mistakes slip in it is easy to > bisect them. In the process of review what it takes to remove > task_rcu_dereference I found

Re: [PATCH 0/3] task: Making tasks on the runqueue rcu protected

2019-09-03 Thread Oleg Nesterov
On 09/02, Eric W. Biederman wrote: > > Oleg do you have any issues with this code? OK, let it be refcount_t, I agree it looks more readable. > Eric W. Biederman (3): > task: Add a count of task rcu users > task: RCU protect tasks on the runqueue > task: Clean house now that

[PATCH 0/3] task: Making tasks on the runqueue rcu protected

2019-09-02 Thread Eric W. Biederman
I have split this work into 3 simple patches, so the code is straight forward to review and so that if any mistakes slip in it is easy to bisect them. In the process of review what it takes to remove task_rcu_dereference I found yet another user of tasks on the runqueue in rcu context; the