Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-19 Thread Joerg Roedel
On Mon, Apr 18, 2016 at 09:43:36AM -0500, Bjorn Helgaas wrote: > That might work, but the problem seems to be that we aren't enabling > IRQs correctly, so I'd rather have a fix that explicitly addresses > IRQs than one that relies on some non-obvious connection between > enabling BARs and IRQs. Ye

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-18 Thread Bjorn Helgaas
On Mon, Apr 18, 2016 at 01:50:15PM +0200, Joerg Roedel wrote: > Hi Bjorn, > > On Fri, Apr 15, 2016 at 10:08:21AM -0500, Bjorn Helgaas wrote: > > I assume you're thinking about doing pci_enable_resources() before > > the core calls the driver's probe method? One question there is how > > we would

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-18 Thread Joerg Roedel
Hi Bjorn, On Fri, Apr 15, 2016 at 10:08:21AM -0500, Bjorn Helgaas wrote: > I assume you're thinking about doing pci_enable_resources() before > the core calls the driver's probe method? One question there is how > we would deal with pci_enable_device_mem(). If the core calls > pci_enable_resourc

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-17 Thread Greg KH
On Wed, Apr 13, 2016 at 12:56:59AM -0500, Bjorn Helgaas wrote: > pcibios_free_irq()" > > Please apply these reverts to the v4.4 stable kernel. > > We reverted the following changes from v4.5 to fix a regression: > > 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled") > 811a

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-15 Thread Bjorn Helgaas
On Thu, Apr 14, 2016 at 05:50:44PM +0200, Joerg Roedel wrote: > Hi Bjorn, > > On Wed, Apr 13, 2016 at 12:56:59AM -0500, Bjorn Helgaas wrote: > > We reverted the following changes from v4.5 to fix a regression: > > > > 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled") > > 8

Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-14 Thread Joerg Roedel
Hi Bjorn, On Wed, Apr 13, 2016 at 12:56:59AM -0500, Bjorn Helgaas wrote: > We reverted the following changes from v4.5 to fix a regression: > > 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled") > 811a4e6fce09 ("PCI: Add helpers to manage pci_dev->irq and > pci_dev->irq_ma

[PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and

2016-04-12 Thread Bjorn Helgaas
pcibios_free_irq()" Please apply these reverts to the v4.4 stable kernel. We reverted the following changes from v4.5 to fix a regression: 8affb487d4a4 ("x86/PCI: Don't alloc pcibios-irq when MSI is enabled") 811a4e6fce09 ("PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed")