Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Chuck Lever III
> On Mar 23, 2021, at 10:45 AM, Mel Gorman wrote: > > On Tue, Mar 23, 2021 at 12:08:51PM +0100, Jesper Dangaard Brouer wrote: My results show that, because svc_alloc_arg() ends up calling __alloc_pages_bulk() twice in this case, it ends up being twice as expensive as the

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Jesper Dangaard Brouer
On Tue, 23 Mar 2021 16:08:14 +0100 Jesper Dangaard Brouer wrote: > On Tue, 23 Mar 2021 10:44:21 + > Mel Gorman wrote: > > > On Mon, Mar 22, 2021 at 09:18:42AM +, Mel Gorman wrote: > > > This series is based on top of Matthew Wilcox's series "Rationalise > > > __alloc_pages wrapper"

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Mel Gorman
On Tue, Mar 23, 2021 at 04:08:14PM +0100, Jesper Dangaard Brouer wrote: > On Tue, 23 Mar 2021 10:44:21 + > Mel Gorman wrote: > > > On Mon, Mar 22, 2021 at 09:18:42AM +, Mel Gorman wrote: > > > This series is based on top of Matthew Wilcox's series "Rationalise > > > __alloc_pages

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Jesper Dangaard Brouer
On Tue, 23 Mar 2021 10:44:21 + Mel Gorman wrote: > On Mon, Mar 22, 2021 at 09:18:42AM +, Mel Gorman wrote: > > This series is based on top of Matthew Wilcox's series "Rationalise > > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > > test and are not using Andrew's

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Mel Gorman
On Tue, Mar 23, 2021 at 12:08:51PM +0100, Jesper Dangaard Brouer wrote: > > > > > > My results show that, because svc_alloc_arg() ends up calling > > > __alloc_pages_bulk() twice in this case, it ends up being > > > twice as expensive as the list case, on average, for the same > > > workload. > >

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Matthew Wilcox
On Mon, Mar 22, 2021 at 08:32:54PM +, Chuck Lever III wrote: > > It's not expected that the array implementation would be worse *unless* > > you are passing in arrays with holes in the middle. Otherwise, the success > > rate should be similar. > > Essentially, sunrpc will always pass an array

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Jesper Dangaard Brouer
On Mon, 22 Mar 2021 20:58:27 + Mel Gorman wrote: > On Mon, Mar 22, 2021 at 08:32:54PM +, Chuck Lever III wrote: > > >> It is returning some confusing (to me) results. I'd like > > >> to get these resolved before posting any benchmark > > >> results. > > >> > > >> 1. When it has visited

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-23 Thread Mel Gorman
On Mon, Mar 22, 2021 at 09:18:42AM +, Mel Gorman wrote: > This series is based on top of Matthew Wilcox's series "Rationalise > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > test and are not using Andrew's tree as a baseline, I suggest using the > following git tree >

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Mel Gorman
On Mon, Mar 22, 2021 at 08:32:54PM +, Chuck Lever III wrote: > >> It is returning some confusing (to me) results. I'd like > >> to get these resolved before posting any benchmark > >> results. > >> > >> 1. When it has visited every array element, it returns the > >> same value as was passed

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Chuck Lever III
> On Mar 22, 2021, at 3:49 PM, Mel Gorman wrote: > > On Mon, Mar 22, 2021 at 06:25:03PM +, Chuck Lever III wrote: >> >> >>> On Mar 22, 2021, at 5:18 AM, Mel Gorman wrote: >>> >>> This series is based on top of Matthew Wilcox's series "Rationalise >>> __alloc_pages wrapper" and does

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Mel Gorman
On Mon, Mar 22, 2021 at 06:25:03PM +, Chuck Lever III wrote: > > > > On Mar 22, 2021, at 5:18 AM, Mel Gorman wrote: > > > > This series is based on top of Matthew Wilcox's series "Rationalise > > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > > test and are not

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Chuck Lever III
> On Mar 22, 2021, at 5:18 AM, Mel Gorman wrote: > > This series is based on top of Matthew Wilcox's series "Rationalise > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > test and are not using Andrew's tree as a baseline, I suggest using the > following git tree > >

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Mel Gorman
On Mon, Mar 22, 2021 at 01:04:46PM +0100, Jesper Dangaard Brouer wrote: > On Mon, 22 Mar 2021 09:18:42 + > Mel Gorman wrote: > > > This series is based on top of Matthew Wilcox's series "Rationalise > > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > > test and are

Re: [PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Jesper Dangaard Brouer
On Mon, 22 Mar 2021 09:18:42 + Mel Gorman wrote: > This series is based on top of Matthew Wilcox's series "Rationalise > __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to > test and are not using Andrew's tree as a baseline, I suggest using the > following git tree > >

[PATCH 0/3 v5] Introduce a bulk order-0 page allocator

2021-03-22 Thread Mel Gorman
This series is based on top of Matthew Wilcox's series "Rationalise __alloc_pages wrapper" and does not apply to 5.12-rc2. If you want to test and are not using Andrew's tree as a baseline, I suggest using the following git tree git://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git