Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Kees Cook
On Wed, Jul 08, 2020 at 01:30:04PM +, Luis Chamberlain wrote: > On Wed, Jul 08, 2020 at 01:58:47PM +0200, Hans de Goede wrote: > > Hi, > > > > On 7/8/20 1:55 PM, Luis Chamberlain wrote: > > > On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 7/8/20

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 01:58:47PM +0200, Hans de Goede wrote: > Hi, > > On 7/8/20 1:55 PM, Luis Chamberlain wrote: > > On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 7/8/20 1:01 PM, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 7/7/20 10:19 AM, Kee

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Hans de Goede
Hi, On 7/8/20 1:55 PM, Luis Chamberlain wrote: On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: Hi, On 7/8/20 1:01 PM, Hans de Goede wrote: Hi, On 7/7/20 10:19 AM, Kees Cook wrote: Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I no

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote: > Hi, > > On 7/8/20 1:01 PM, Hans de Goede wrote: > > Hi, > > > > On 7/7/20 10:19 AM, Kees Cook wrote: > > > Hi, > > > > > > In looking for closely at the additions that got made to the > > > kernel_read_file() enums, I noticed that

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Hans de Goede
Hi, On 7/8/20 1:01 PM, Hans de Goede wrote: Hi, On 7/7/20 10:19 AM, Kees Cook wrote: Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate *kinds* of

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-08 Thread Hans de Goede
Hi, On 7/7/20 10:19 AM, Kees Cook wrote: Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate *kinds* of files for the LSM to reason about. They are a

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-07 Thread Kees Cook
On Tue, Jul 07, 2020 at 11:36:04AM -0400, Mimi Zohar wrote: > Hi Kees, > > On Tue, 2020-07-07 at 01:19 -0700, Kees Cook wrote: > > Hi, > > > > In looking for closely at the additions that got made to the > > kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER > > and FIRMWARE_EFI_EM

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-07 Thread Mimi Zohar
Hi Kees, On Tue, 2020-07-07 at 01:19 -0700, Kees Cook wrote: > Hi, > > In looking for closely at the additions that got made to the > kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER > and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate > *kinds* of files for the L

Re: [PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-07 Thread Greg Kroah-Hartman
On Tue, Jul 07, 2020 at 01:19:22AM -0700, Kees Cook wrote: > Hi, > > In looking for closely at the additions that got made to the > kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER > and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate > *kinds* of files for the LSM

[PATCH 0/4] Fix misused kernel_read_file() enums

2020-07-07 Thread Kees Cook
Hi, In looking for closely at the additions that got made to the kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate *kinds* of files for the LSM to reason about. They are a "how" and "where", respectively. Remove the