Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Alan Cox
> So, why is ide-scsi still in the tree? Is there some use case besides > cdrecord? (Which can use /dev/hda already without the ide-scsi blob...) With old IDE only ide-scsi can handle some of the more obscurely weird devices, and some tape drives fail with ide-tape but work with ide-scsi +

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Jan Engelhardt
On Feb 12 2008 01:09, Bartlomiej Zolnierkiewicz wrote: > >> On a different note, i noticed ide-scsi might also need a cleanup >> similar to the other drivers. It is next on my TODO list in case >> you don't have anything with a higher prio. > >I was actually hoping that you'll continue unifying

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Jan Engelhardt
On Feb 12 2008 01:09, Bartlomiej Zolnierkiewicz wrote: On a different note, i noticed ide-scsi might also need a cleanup similar to the other drivers. It is next on my TODO list in case you don't have anything with a higher prio. I was actually hoping that you'll continue unifying ATAPI

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Alan Cox
So, why is ide-scsi still in the tree? Is there some use case besides cdrecord? (Which can use /dev/hda already without the ide-scsi blob...) With old IDE only ide-scsi can handle some of the more obscurely weird devices, and some tape drives fail with ide-tape but work with ide-scsi +

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Borislav Petkov
On Tue, Feb 12, 2008 at 01:09:24AM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday 11 February 2008, Borislav Petkov wrote: > > Hi Bart, > > > > here's the ide_atapi_pc unification series. It all went pretty smoothly > > along > > the search & replace line. Using driver-specific members

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Borislav Petkov wrote: > Hi Bart, > > here's the ide_atapi_pc unification series. It all went pretty smoothly along > the search & replace line. Using driver-specific members in ide_atapi_pc like > idefloppy_callback and idetape_callback is kinda dumb but this

[PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Borislav Petkov
Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search & replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach seemed the fastest versus unnecessary callback function

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Borislav Petkov
On Tue, Feb 12, 2008 at 01:09:24AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 11 February 2008, Borislav Petkov wrote: Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members in

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Borislav Petkov wrote: Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach