RE: [PATCH 0/4] int to bool conversion

2015-02-18 Thread Moore, Robert
Quentin Lambert > Cc: Zhang, Rui; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; > Shaohua Li; linux-a...@vger.kernel.org; de...@acpica.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 0/4] int to bool conversion > > On Monday, January 26, 2015 09:30:55 AM Quentin L

Re: [PATCH 0/4] int to bool conversion

2015-01-30 Thread Peter Hurley
Hi Louis, On 01/30/2015 12:32 PM, Louis Langholtz wrote: > While it may not be productive to perturb seemingly working > code (as Rafael argues), it may also not be productive to > have decreased code readability (as Quentin suggests). > > Personally I prefer readability enhancements over worryin

Re: [PATCH 0/4] int to bool conversion

2015-01-30 Thread Louis Langholtz
While it may not be productive to perturb seemingly working code (as Rafael argues), it may also not be productive to have decreased code readability (as Quentin suggests). Personally I prefer readability enhancements over worrying about possibly breaking working code. I don't want to start a flam

Re: [PATCH 0/4] int to bool conversion

2015-01-26 Thread Rafael J. Wysocki
On Monday, January 26, 2015 09:30:55 AM Quentin Lambert wrote: > Sorry for the delay in answering > > On 22/01/2015 17:18, Rafael J. Wysocki wrote: > > On Thursday, January 22, 2015 09:49:41 AM Quentin Lambert wrote: > >> These patches convert local variables from int to bool when relevant. >

Re: [PATCH 0/4] int to bool conversion

2015-01-26 Thread Quentin Lambert
Sorry for the delay in answering On 22/01/2015 17:18, Rafael J. Wysocki wrote: On Thursday, January 22, 2015 09:49:41 AM Quentin Lambert wrote: These patches convert local variables from int to bool when relevant. And what exactly is the need for that? Does that fix any functional proble

Re: [PATCH 0/4] int to bool conversion

2015-01-22 Thread Rafael J. Wysocki
On Thursday, January 22, 2015 09:49:41 AM Quentin Lambert wrote: > These patches convert local variables from int to bool when relevant. And what exactly is the need for that? Does that fix any functional problems? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Cen

[PATCH 0/4] int to bool conversion

2015-01-22 Thread Quentin Lambert
These patches convert local variables from int to bool when relevant. The first patch proposes straight forward cases where the conversion do not suggest changes beyond the function. The second patch deals with cases where the conversion is propagated to function parameters. The third patch is a