Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-28 Thread Davidlohr Bueso
*sigh* it seems that the email this morning wasn't sent, resending... On Mon, 2013-05-27 at 17:57 +0200, Manfred Spraul wrote: > Hi Davidlohr, > > On 05/26/2013 10:50 PM, Davidlohr Bueso wrote: > > > > In lack of getting my swingbench DSS environment back, I ran these > > changes against the semo

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-27 Thread Greg KH
On Mon, May 27, 2013 at 01:50:38PM -0400, Rik van Riel wrote: > On 05/26/2013 10:04 PM, Greg KH wrote: > >On Sun, May 26, 2013 at 11:08:51AM +0200, Manfred Spraul wrote: > >>I've split my patch into 4 parts: > >>- 1: Fix-missing-wakeups-in-do_smart_update > >>- 2: seperate-wait-for-zero-and-alter-t

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-27 Thread Rik van Riel
On 05/26/2013 10:04 PM, Greg KH wrote: On Sun, May 26, 2013 at 11:08:51AM +0200, Manfred Spraul wrote: I've split my patch into 4 parts: - 1: Fix-missing-wakeups-in-do_smart_update - 2: seperate-wait-for-zero-and-alter-tasks - 3: Always-use-only-one-queue-for-alter-operations - 4: Rename-try_ato

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-27 Thread Manfred Spraul
Hi Davidlohr, On 05/26/2013 10:50 PM, Davidlohr Bueso wrote: In lack of getting my swingbench DSS environment back, I ran these changes against the semop-multi program on my laptop. For 256 threads, with Manfred's patchset the ops/sec suffers around -7.3%. Could you also check the performance

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-26 Thread Greg KH
On Sun, May 26, 2013 at 11:08:51AM +0200, Manfred Spraul wrote: > I've split my patch into 4 parts: > - 1: Fix-missing-wakeups-in-do_smart_update > - 2: seperate-wait-for-zero-and-alter-tasks > - 3: Always-use-only-one-queue-for-alter-operations > - 4: Rename-try_atomic_semop-to-perform_atomic > >

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-26 Thread Linus Torvalds
On Sun, May 26, 2013 at 1:50 PM, Davidlohr Bueso wrote: > > In lack of getting my swingbench DSS environment back, I ran these > changes against the semop-multi program on my laptop. For 256 threads, > with Manfred's patchset the ops/sec suffers around -7.3%. Hmm. That test program only tests sim

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-26 Thread Davidlohr Bueso
On Sun, 2013-05-26 at 11:08 +0200, Manfred Spraul wrote: > I've split my patch into 4 parts: > - 1: Fix-missing-wakeups-in-do_smart_update > - 2: seperate-wait-for-zero-and-alter-tasks > - 3: Always-use-only-one-queue-for-alter-operations > - 4: Rename-try_atomic_semop-to-perform_atomic > > Linus:

Re: [PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-26 Thread Linus Torvalds
On Sun, May 26, 2013 at 2:08 AM, Manfred Spraul wrote: > I've split my patch into 4 parts: > - 1: Fix-missing-wakeups-in-do_smart_update > - 2: seperate-wait-for-zero-and-alter-tasks > - 3: Always-use-only-one-queue-for-alter-operations > - 4: Rename-try_atomic_semop-to-perform_atomic Rik, Davidl

[PATCH 0/4] ipc/sem.c: Bug fixes, regression fixes, v3

2013-05-26 Thread Manfred Spraul
I've split my patch into 4 parts: - 1: Fix-missing-wakeups-in-do_smart_update - 2: seperate-wait-for-zero-and-alter-tasks - 3: Always-use-only-one-queue-for-alter-operations - 4: Rename-try_atomic_semop-to-perform_atomic Linus: - Patch 1 should be merged immediately: It fixes bugs, the current c