Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-12 Thread Roman Gushchin
On Mon, Mar 11, 2019 at 07:38:28PM -0700, Matthew Wilcox wrote: > On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote: > > > slab_list and lru are in the same bits. Once this patch set is in, > > > we can remove the enigmatic 'uses lru' comment that I added. > > > > Funny you should

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-12 Thread Roman Gushchin
On Tue, Mar 12, 2019 at 01:01:53PM +1100, Tobin C. Harding wrote: > On Tue, Mar 12, 2019 at 12:22:23AM +, Roman Gushchin wrote: > > On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote: > > > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > > > > The patchset looks go

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Tobin C. Harding
On Mon, Mar 11, 2019 at 07:38:28PM -0700, Matthew Wilcox wrote: > On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote: > > > slab_list and lru are in the same bits. Once this patch set is in, > > > we can remove the enigmatic 'uses lru' comment that I added. > > > > Funny you should

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Matthew Wilcox
On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote: > > slab_list and lru are in the same bits. Once this patch set is in, > > we can remove the enigmatic 'uses lru' comment that I added. > > Funny you should say this, I came to me today while daydreaming that I > should have remove

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Tobin C. Harding
On Tue, Mar 12, 2019 at 12:22:23AM +, Roman Gushchin wrote: > On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote: > > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > > > The patchset looks good to me, however I'd add some clarifications > > > why switching from lru

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Tobin C. Harding
On Tue, Mar 12, 2019 at 12:22:23AM +, Roman Gushchin wrote: > On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote: > > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > > > The patchset looks good to me, however I'd add some clarifications > > > why switching from lru

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Tobin C. Harding
On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote: > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > > The patchset looks good to me, however I'd add some clarifications > > why switching from lru to slab_list is safe. > > > > My understanding is that the slab_list f

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Roman Gushchin
On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote: > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > > The patchset looks good to me, however I'd add some clarifications > > why switching from lru to slab_list is safe. > > > > My understanding is that the slab_list f

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Matthew Wilcox
On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote: > The patchset looks good to me, however I'd add some clarifications > why switching from lru to slab_list is safe. > > My understanding is that the slab_list fields isn't currently in use, > but it's not that obvious that putting sla

Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-11 Thread Roman Gushchin
On Mon, Mar 11, 2019 at 12:07:40PM +1100, Tobin C. Harding wrote: > Currently the slab allocators (ab)use the struct page 'lru' list_head. > We have a list head for slab allocators to use, 'slab_list'. > > Clean up all three allocators by using the 'slab_list' list_head instead > of overloading th

[PATCH 0/4] mm: Use slab_list list_head instead of lru

2019-03-10 Thread Tobin C. Harding
Currently the slab allocators (ab)use the struct page 'lru' list_head. We have a list head for slab allocators to use, 'slab_list'. Clean up all three allocators by using the 'slab_list' list_head instead of overloading the 'lru' list_head. Initial patch makes no code changes, adds comments to #e