Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
On Fri, 6 Apr 2018 21:34:24 +0200 Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 03:19:23PM -0400, Steven Rostedt wrote: > > > > Peter, Andrew, > > > > This keeps initcall_debug printing printk()s, but adds the feature of > > those locations also being trace events. Are

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
On Fri, 6 Apr 2018 21:34:24 +0200 Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 03:19:23PM -0400, Steven Rostedt wrote: > > > > Peter, Andrew, > > > > This keeps initcall_debug printing printk()s, but adds the feature of > > those locations also being trace events. Are you OK if I add this?

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Peter Zijlstra
On Fri, Apr 06, 2018 at 03:19:23PM -0400, Steven Rostedt wrote: > > Peter, Andrew, > > This keeps initcall_debug printing printk()s, but adds the feature of > those locations also being trace events. Are you OK if I add this? Yeah, I don't see any real problems with it.

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Peter Zijlstra
On Fri, Apr 06, 2018 at 03:19:23PM -0400, Steven Rostedt wrote: > > Peter, Andrew, > > This keeps initcall_debug printing printk()s, but adds the feature of > those locations also being trace events. Are you OK if I add this? Yeah, I don't see any real problems with it.

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
Peter, Andrew, This keeps initcall_debug printing printk()s, but adds the feature of those locations also being trace events. Are you OK if I add this? Works with and without TRACEPOINTS enabled. -- Steve On Fri, 06 Apr 2018 15:08:54 -0400 Steven Rostedt wrote: > A

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
Peter, Andrew, This keeps initcall_debug printing printk()s, but adds the feature of those locations also being trace events. Are you OK if I add this? Works with and without TRACEPOINTS enabled. -- Steve On Fri, 06 Apr 2018 15:08:54 -0400 Steven Rostedt wrote: > A while ago we had a boot

[PATCH 0/4 v2] init, tracing:

2018-04-06 Thread Steven Rostedt
A while ago we had a boot tracer. But it was eventually removed: commit 30dbb20e68e6f ("tracing: Remove boot tracer"). The rationale was because there is already a initcall_debug boot option that causes printk()s of all the initcall functions. The problem with the initcall_debug option is that

[PATCH 0/4 v2] init, tracing:

2018-04-06 Thread Steven Rostedt
A while ago we had a boot tracer. But it was eventually removed: commit 30dbb20e68e6f ("tracing: Remove boot tracer"). The rationale was because there is already a initcall_debug boot option that causes printk()s of all the initcall functions. The problem with the initcall_debug option is that

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
Bah, Saved the cover letter before putting back in the original subject. -- Steve

Re: [PATCH 0/4 v2] init, tracing: Add initcall trace events

2018-04-06 Thread Steven Rostedt
Bah, Saved the cover letter before putting back in the original subject. -- Steve