Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-12 Thread Matthias Brugger
On Thursday, June 11, 2015 04:52:12 PM Stephen Boyd wrote: > On 06/08, Sascha Hauer wrote: > > On Fri, Jun 05, 2015 at 05:59:12PM -0700, Stephen Boyd wrote: > > > And similar things could be done for the reset driver. > > > > The problem I see with this approach is that we scatter the code for a >

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-11 Thread Stephen Boyd
On 06/08, Sascha Hauer wrote: > On Fri, Jun 05, 2015 at 05:59:12PM -0700, Stephen Boyd wrote: > > > > And similar things could be done for the reset driver. > > The problem I see with this approach is that we scatter the code for a > otherwise simple driver over a bunch of directories. We would h

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-08 Thread Sascha Hauer
On Fri, Jun 05, 2015 at 05:59:12PM -0700, Stephen Boyd wrote: > On 06/05, James Liao wrote: > > Hi Stephen, > > > > On Thu, 2015-06-04 at 14:02 -0700, Stephen Boyd wrote: > > > On 05/29, Sascha Hauer wrote: > > > > Yes. I previously got the impression that the subsystem clocks are not > > > > dire

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-08 Thread James Liao
Hi Stephen, On Fri, 2015-06-05 at 17:59 -0700, Stephen Boyd wrote: > Perhaps an example would be best. In DT we would have: > > vencsys: vencsys@1 { > compatible = "mtk,vencsys"; > reg = <0x1 0x1000>; > #clock-cells = <1>; > #r

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-05 Thread Stephen Boyd
On 06/05, James Liao wrote: > Hi Stephen, > > On Thu, 2015-06-04 at 14:02 -0700, Stephen Boyd wrote: > > On 05/29, Sascha Hauer wrote: > > > Yes. I previously got the impression that the subsystem clocks are not > > > directly associated to the larbs, but needed to be handled by the larb > > > cod

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-04 Thread James Liao
Hi Stephen, On Thu, 2015-06-04 at 14:02 -0700, Stephen Boyd wrote: > On 05/29, Sascha Hauer wrote: > > Yes. I previously got the impression that the subsystem clocks are not > > directly associated to the larbs, but needed to be handled by the larb > > code due to some side effect. Now that I saw

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-06-04 Thread Stephen Boyd
On 05/29, Sascha Hauer wrote: > On Fri, May 29, 2015 at 10:47:29AM +0800, James Liao wrote: > > Hi Sascha, > > > > > And really the driver matching "mediatek,mt8173-vencsys" should register > > > the necessary clocks and reset lines and call of_platform_populate on > > > the subnodes. The driver s

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-05-28 Thread Sascha Hauer
On Fri, May 29, 2015 at 10:47:29AM +0800, James Liao wrote: > Hi Sascha, > > > And really the driver matching "mediatek,mt8173-vencsys" should register > > the necessary clocks and reset lines and call of_platform_populate on > > the subnodes. The driver should also be a real driver, not something

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-05-28 Thread James Liao
Hi Sascha, On Thu, 2015-05-28 at 15:24 +0200, Sascha Hauer wrote: > On Thu, May 21, 2015 at 03:12:51PM +0800, James Liao wrote: > > This patchset contains subsystem clocks support for Mediatek MT8173. > > It also contains some bug fixes before adds new clocks support. > > > > James Liao (4): > >

Re: [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-05-28 Thread Sascha Hauer
On Thu, May 21, 2015 at 03:12:51PM +0800, James Liao wrote: > This patchset contains subsystem clocks support for Mediatek MT8173. > It also contains some bug fixes before adds new clocks support. > > James Liao (4): > clk: mediatek: Fix apmixedsys clock registration > dt-bindings: ARM: Mediat

[PATCH 0/5] Add Mediatek MT8173 subsystem clocks support

2015-05-21 Thread James Liao
This patchset contains subsystem clocks support for Mediatek MT8173. It also contains some bug fixes before adds new clocks support. James Liao (4): clk: mediatek: Fix apmixedsys clock registration dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers clk: mediat