Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules

2017-03-26 Thread Leo Yan
On Sun, Mar 26, 2017 at 05:20:50PM +0200, Alexandre Belloni wrote: > On 26/03/2017 at 22:41:49 +0800, Leo Yan wrote: > > When review device driver modules which attach to amba bus, found > > several modules are not using devm_*() apis to manage resource. As > > result, some drivers have memory leak

Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules

2017-03-26 Thread Alexandre Belloni
On 26/03/2017 at 22:41:49 +0800, Leo Yan wrote: > When review device driver modules which attach to amba bus, found > several modules are not using devm_*() apis to manage resource. As > result, some drivers have memory leakage or missing iomem unmapping > when rmmod module. And the code has many "

[PATCH 0/5] Convert to use devm_*() for amba attached modules

2017-03-26 Thread Leo Yan
When review device driver modules which attach to amba bus, found several modules are not using devm_*() apis to manage resource. As result, some drivers have memory leakage or missing iomem unmapping when rmmod module. And the code has many "goto" tags to handle different failures. So this patch